[GitHub] [isis] andi-huber commented on a change in pull request #507: ISIS-2015: Text can be changed on non-editable field, without using edit

[GitBox <gi...@apache.org>]

andi-huber commented on a change in pull request #507:
URL: https://github.com/apache/isis/pull/507#discussion_r617215434



##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/bootstrap-overrides-all-v2.css
##########
@@ -979,6 +979,10 @@ li.select2-results__option {
     padding-right: 15px;
 }
 
+.multiLineStringPanel .scalarValueInlinePromptLink textarea {
+    background-color: white;

Review comment:
       It might not be a good idea to hard-code a color value that way, as there are different bootstrap themes one can choose to use. There are also fancy 'dark' themes that would require the 'opposite' color.

##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/pages/bootstrap-overrides-all-v1.css
##########
@@ -950,6 +950,10 @@ li.select2-results__option {
     padding-right: 15px;
 }
 
+.multiLineStringPanel .scalarValueInlinePromptLink textarea {

Review comment:
       I believe bootstrap-overrides-all-v1.css is no longer used, we might as well delete this file.

##########
File path: viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelTextFieldAbstract.html
##########
@@ -86,7 +86,7 @@
     </wicket:fragment>
 
     <wicket:fragment wicket:id="textareaInlinePrompt">
-        <textarea class="form-control input-sm" wicket:id="scalarValue"></textarea>
+        <textarea class="form-control input-sm" wicket:id="scalarValue" readonly="readonly"></textarea>

Review comment:
       I believe this is valid, but unfortunately changes the appearance, which we yet have not found a way to fix without a headache considering there are different bootstrap themes a user can choose. I figure the CSS fix you are suggesting works for some themes, but unfortunately not for all of them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org