You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2021/05/06 16:22:02 UTC
[GitHub] [shiro] bdemers opened a new pull request #298: Pr 297 to main
bdemers opened a new pull request #298:
URL: https://github.com/apache/shiro/pull/298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell commented on a change in pull request #298: Pr 297 to main
Posted by GitBox <gi...@apache.org>.
bmarwell commented on a change in pull request #298:
URL: https://github.com/apache/shiro/pull/298#discussion_r627950773
##########
File path: .jenkins.groovy
##########
@@ -17,6 +17,8 @@
* under the License.
*/
+def supportedBranch = env.BRANCH_NAME ==~ /(1.7.x|1.8.x|main)/
Review comment:
"supported"? Like in "we give support"? Maybe just change to "deployable branch" or "maintained" or something like this. It should be clear that this *only* has to do with snapshot deployments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bdemers commented on a change in pull request #298: Pr 297 to main
Posted by GitBox <gi...@apache.org>.
bdemers commented on a change in pull request #298:
URL: https://github.com/apache/shiro/pull/298#discussion_r628233560
##########
File path: .jenkins.groovy
##########
@@ -17,6 +17,8 @@
* under the License.
*/
+def supportedBranch = env.BRANCH_NAME ==~ /(1.7.x|1.8.x|main)/
Review comment:
Good call, I wasn't happy with this name either, `deployableBranch` sounds good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bdemers commented on a change in pull request #298: Pr 297 to main
Posted by GitBox <gi...@apache.org>.
bdemers commented on a change in pull request #298:
URL: https://github.com/apache/shiro/pull/298#discussion_r628328725
##########
File path: .jenkins.groovy
##########
@@ -17,6 +17,8 @@
* under the License.
*/
+def supportedBranch = env.BRANCH_NAME ==~ /(1.7.x|1.8.x|main)/
Review comment:
@bmarwell back to you when you get a chance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bdemers merged pull request #298: Pr 297 to main
Posted by GitBox <gi...@apache.org>.
bdemers merged pull request #298:
URL: https://github.com/apache/shiro/pull/298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org