[jira] [Comment Edited] (JCLOUDS-85) Avoid creating uneeded instance of PropertyShellTableFactory

["TangYong (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCLOUDS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693208#comment-13693208 ] 

TangYong edited comment on JCLOUDS-85 at 6/25/13 5:58 PM:
----------------------------------------------------------

pl. Ioannis or Andrew see whether should updates Fix Version/s into 1.7 and I will do a fix. From JCLOUDS-83's apache git commit message, I will notice the final commit message from github.


                
      was (Author: tangyong):
    pl. Ioannis or Andrew see whether should updates Fix Version/s into 1.7 and I will do a fix. From JCLOUDS-83's apache git commit message, I will notice the final commit message from github.


                  
> Avoid creating uneeded instance of PropertyShellTableFactory
> ------------------------------------------------------------
>
>                 Key: JCLOUDS-85
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-85
>             Project: jclouds
>          Issue Type: Improvement
>          Components: jclouds-karaf
>    Affects Versions: 1.7.0, 1.6.1, 1.5.11
>            Reporter: Ioannis Canellos
>
> The story here is that we have 2 versions of the ShellTableFactory:
> i) OSGi aware
> ii) Property based
> Our commands always instantiate (ii) and may replace it with (i) when running inside OSGi.
> We should make sure that we instantiate (ii) only if no injection takes place (e.g. outside OSGi)
> This could be as simple as checking if the factory is null inside the doExecute method and then instantiating (ii).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira