You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/12/06 19:23:03 UTC

[Impala-ASF-CR] IMPALA-7926: Fix flakiness in test reconnect

Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12045


Change subject: IMPALA-7926: Fix flakiness in test_reconnect
......................................................................

IMPALA-7926: Fix flakiness in test_reconnect

test_reconnect launches a shell that connects to one impalad in the
minicluster then reconnects to a different impalad while checking that
the impalad's open session metric changes accordingly.

To do this, the test gets the number of open sessions at the start of
the test and then expects that the number of sessions will have
increased by 1 on the impalad that the shell is currently connected
to.

This can be a problem if there is a session left over from another
test that is still active when test_reconnect starts but exits while
it's running.

test_reconnect is already marked to run serially, so there shouldn't
be any other sessions open while it runs anyways. The solution is to
wait at the start of the test until any sessions left over from other
tests have exited.

Testing:
- Ran the test in an environment where the timing was previously
  causing it to fail almost deterministically and it now passes.

Change-Id: I3017ca3bf7b4e33440cffb80e9a48a63bec14434
---
M tests/shell/test_shell_interactive.py
1 file changed, 11 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/12045/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3017ca3bf7b4e33440cffb80e9a48a63bec14434
Gerrit-Change-Number: 12045
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>

[Impala-ASF-CR] IMPALA-7926: Fix flakiness in test reconnect

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.

Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12045 )

Change subject: IMPALA-7926: Fix flakiness in test_reconnect
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12045/1/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/12045/1/tests/shell/test_shell_interactive.py@235
PS1, Line 235:         beeswax_port=21001, be_port=22001)
> The default value for wait_for_metric_value() is 10 seconds. Will that be e
Yes, testing locally it always takes <1s


http://gerrit.cloudera.org:8080/#/c/12045/1/tests/shell/test_shell_interactive.py@242
PS1, Line 242:     # Connect to localhost:21000 (default)
> If you change get_num_open_sessions to call wait_for_metric_value(), you ca
Done


http://gerrit.cloudera.org:8080/#/c/12045/1/tests/shell/test_shell_interactive.py@253
PS1, Line 253:     assert "[%s:21001] default>" % hostname in p.get_result().stdout
> while you're here remove this and change get_num_open_sessions to call wait
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3017ca3bf7b4e33440cffb80e9a48a63bec14434
Gerrit-Change-Number: 12045
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 10 Dec 2018 19:58:34 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7926: Fix flakiness in test reconnect

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12045 )

Change subject: IMPALA-7926: Fix flakiness in test_reconnect
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3017ca3bf7b4e33440cffb80e9a48a63bec14434
Gerrit-Change-Number: 12045
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Wed, 12 Dec 2018 18:47:44 +0000
Gerrit-HasComments: No