[GitHub] [calcite] vlsi commented on a change in pull request #1719: [CALCITE-3668] VolcanoPlanner does not match all the RelSubSet in matchRecursive

[GitBox <gi...@apache.org>]

vlsi commented on a change in pull request #1719: [CALCITE-3668] VolcanoPlanner does not match all the RelSubSet in matchRecursive
URL: https://github.com/apache/calcite/pull/1719#discussion_r370858438
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java
 ##########
 @@ -317,8 +317,7 @@ private void matchRecurse(int solve) {
           final RelSubset subset =
               (RelSubset) inputs.get(operand.ordinalInParent);
           if (operand.getMatchedClass() == RelSubset.class) {
-            // If the rule wants the whole subset, we just provide it
-            successors = ImmutableList.of(subset);
+            successors = subset.getSubsets();
 
 Review comment:
   The naming is hard.
   `subset.getSubsets()` looks confusing :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services