[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4018: Fix #3904 increase xslt extension test coverage

[GitBox <gi...@apache.org>]

zhfeng commented on code in PR #4018:
URL: https://github.com/apache/camel-quarkus/pull/4018#discussion_r952302516


##########
integration-tests/xml/pom.xml:
##########
@@ -35,14 +35,30 @@
             <groupId>org.apache.camel.quarkus</groupId>
             <artifactId>camel-quarkus-xslt</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.camel.quarkus</groupId>
+            <artifactId>camel-quarkus-xslt-saxon</artifactId>
+        </dependency>
         <dependency>
             <groupId>org.apache.camel.quarkus</groupId>
             <artifactId>camel-quarkus-xpath</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.camel.quarkus</groupId>
+            <artifactId>camel-quarkus-bean</artifactId>
+        </dependency>
         <dependency>
             <groupId>org.apache.camel.quarkus</groupId>
             <artifactId>camel-quarkus-direct</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.camel.quarkus</groupId>
+            <artifactId>camel-quarkus-file</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.camel.quarkus</groupId>
+            <artifactId>camel-quarkus-mock</artifactId>
+        </dependency>

Review Comment:
   @ppalaga `camel-quarkus-bean` is introduce to test with `xslt:bean` schema. And `camel-quarkus-file` and `camel-qurakus-xslt-saxon` are for testing with `Aggregator`.
   
   I think it is good idea to introduce a new XML testing group. But how to group the sub modules? such like `xml-schema` to test all the supported schemas(`classpath`, `ref`, `bean`, `file`, `http`), `xml-aggregate`, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org