You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by Hiteshgautam01 <gi...@git.apache.org> on 2018/03/23 07:37:33 UTC
[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
GitHub user Hiteshgautam01 opened a pull request:
https://github.com/apache/incubator-taverna-mobile/pull/71
Adding myExperiment logo on login screen
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hiteshgautam01/incubator-taverna-mobile login_edits
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-taverna-mobile/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit f6f401efdf4d186ccf6198c7fa7ef6ce10634d9c
Author: Hitesh Gautam <ga...@...>
Date: 2018-03-23T07:31:46Z
Adding myExperiment logo on login screen
----
---
[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
Posted by therajanmaurya <gi...@git.apache.org>.
Github user therajanmaurya commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/71#discussion_r177662253
--- Diff: app/src/main/res/values/strings.xml ---
@@ -232,6 +232,10 @@ limitations under the License.
<string name="pref_key_myexperiment_pass">pref_myexperimentpass</string>
<string name="pref_summary_myexperiment_pass">Myexperiment password</string>
+ <!--Disclaimer:-->
+ <string name="DisclaimerTitle">Disclaimer:</string>
+ <string name="DisclaimerContent">myExperiment's Logo is nothing to do with Apache and is copyright to myExperiment</string>
--- End diff --
same as above strings resource name should be `disclaimer_content` not `DisclaimerContent`.
---
[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-taverna-mobile/pull/71
---
[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
Posted by therajanmaurya <gi...@git.apache.org>.
Github user therajanmaurya commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/71#discussion_r177662099
--- Diff: app/src/main/res/values/strings.xml ---
@@ -232,6 +232,10 @@ limitations under the License.
<string name="pref_key_myexperiment_pass">pref_myexperimentpass</string>
<string name="pref_summary_myexperiment_pass">Myexperiment password</string>
+ <!--Disclaimer:-->
+ <string name="DisclaimerTitle">Disclaimer:</string>
--- End diff --
@Hiteshgautam01 Please follow this coding guidelines, Here your strings resource name should be
`disclaimer_title` not `DisclaimerTitle`. Please make the change.
---
[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
Posted by Hiteshgautam01 <gi...@git.apache.org>.
Github user Hiteshgautam01 commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/71#discussion_r176907833
--- Diff: app/src/main/res/layout/fragment_login.xml ---
@@ -60,16 +60,13 @@
android:orientation="vertical"
android:padding="@dimen/login_layout_padding">
- <TextView
- android:id="@+id/tvLoginInfo"
+ <ImageView
+ android:id="@+id/myExperimentIcon"
android:layout_width="wrap_content"
- android:layout_height="wrap_content"
+ android:layout_height="@dimen/myExperimentLogoHeight"
android:layout_gravity="center"
- android:background="@color/grey_background"
- android:padding="@dimen/login_info_padding"
- android:text="@string/logininfo"
- android:textSize="@dimen/login_text_size"
- android:textStyle="normal|bold" />
+ android:src="@drawable/myexlogo"
--- End diff --
@saketkumar95 I have tested on different screens and it looks perfect just because of linear layout.
---
[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
Posted by therajanmaurya <gi...@git.apache.org>.
Github user therajanmaurya commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/71#discussion_r177662430
--- Diff: app/src/main/res/values/strings.xml ---
@@ -32,7 +32,7 @@ limitations under the License.
<item>Date Last Run</item>
</array>
<string name="hello_blank_fragment">About Workflow</string>
- <string name="logininfo">myExperiment Login</string>
+ <string name="logininfo">Login</string>
--- End diff --
make the `logininfo` to `login_info`.
---
[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
Posted by therajanmaurya <gi...@git.apache.org>.
Github user therajanmaurya commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/71#discussion_r177662607
--- Diff: app/src/main/res/values/dimens.xml ---
@@ -71,15 +71,18 @@ limitations under the License.
<dimen name="layout_padding">8dp</dimen>
<dimen name="text_size">25sp</dimen>
<dimen name="login_layout_padding">20dp</dimen>
- <dimen name="login_layout_marginTop">20dp</dimen>
- <dimen name="login_info_padding">10dp</dimen>
+ <dimen name="login_layout_marginTop">15dp</dimen>
+ <dimen name="login_info_padding">7dp</dimen>
+ <dimen name="myExperimentLogoHeight">50dp</dimen>
<dimen name="login_text_size">20sp</dimen>
<dimen name="input_layout_email_margin">20dp</dimen>
<dimen name="loginButton_marginBottom">8dp</dimen>
<dimen name="loginButton_marginTop">10dp</dimen>
<dimen name="appName_text_margin">12dp</dimen>
<dimen name="title_text_size">40sp</dimen>
<dimen name="logo_margin_top">40dp</dimen>
+ <dimen name="discTextsize">5dp</dimen>
+ <dimen name="discMarginTop">10dp</dimen>
--- End diff --
please rename the resource name with `disc_margin_top`
---
[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
Posted by sagar15795 <gi...@git.apache.org>.
Github user sagar15795 commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/71#discussion_r177642987
--- Diff: app/src/main/assets/apache_licence_notice.html ---
@@ -229,6 +229,8 @@
Apache Taverna Mobile
Copyright 2015-2018 The Apache Software Foundation
+1.Disclaimer: myExperiment's Logo is nothing to do with Apache and is copyright to myExperiment.
--- End diff --
move it line no 236. just add `myExperiment's Logo is nothing to do with Apache and is copyright to myExperiment.`.
---
[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
Posted by therajanmaurya <gi...@git.apache.org>.
Github user therajanmaurya commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/71#discussion_r177662775
--- Diff: app/src/main/res/values/dimens.xml ---
@@ -71,15 +71,18 @@ limitations under the License.
<dimen name="layout_padding">8dp</dimen>
<dimen name="text_size">25sp</dimen>
<dimen name="login_layout_padding">20dp</dimen>
- <dimen name="login_layout_marginTop">20dp</dimen>
- <dimen name="login_info_padding">10dp</dimen>
+ <dimen name="login_layout_marginTop">15dp</dimen>
+ <dimen name="login_info_padding">7dp</dimen>
+ <dimen name="myExperimentLogoHeight">50dp</dimen>
--- End diff --
please rename the resource name with `my_experiment_logo_height`
---
[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
Posted by therajanmaurya <gi...@git.apache.org>.
Github user therajanmaurya commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/71#discussion_r177662663
--- Diff: app/src/main/res/values/dimens.xml ---
@@ -71,15 +71,18 @@ limitations under the License.
<dimen name="layout_padding">8dp</dimen>
<dimen name="text_size">25sp</dimen>
<dimen name="login_layout_padding">20dp</dimen>
- <dimen name="login_layout_marginTop">20dp</dimen>
- <dimen name="login_info_padding">10dp</dimen>
+ <dimen name="login_layout_marginTop">15dp</dimen>
+ <dimen name="login_info_padding">7dp</dimen>
+ <dimen name="myExperimentLogoHeight">50dp</dimen>
<dimen name="login_text_size">20sp</dimen>
<dimen name="input_layout_email_margin">20dp</dimen>
<dimen name="loginButton_marginBottom">8dp</dimen>
<dimen name="loginButton_marginTop">10dp</dimen>
<dimen name="appName_text_margin">12dp</dimen>
<dimen name="title_text_size">40sp</dimen>
<dimen name="logo_margin_top">40dp</dimen>
+ <dimen name="discTextsize">5dp</dimen>
--- End diff --
please rename the resource name with `disc_text_size `
---
[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
Posted by saketkumar95 <gi...@git.apache.org>.
Github user saketkumar95 commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/71#discussion_r176906647
--- Diff: app/src/main/res/layout/fragment_login.xml ---
@@ -60,16 +60,13 @@
android:orientation="vertical"
android:padding="@dimen/login_layout_padding">
- <TextView
- android:id="@+id/tvLoginInfo"
+ <ImageView
+ android:id="@+id/myExperimentIcon"
android:layout_width="wrap_content"
- android:layout_height="wrap_content"
+ android:layout_height="@dimen/myExperimentLogoHeight"
android:layout_gravity="center"
- android:background="@color/grey_background"
- android:padding="@dimen/login_info_padding"
- android:text="@string/logininfo"
- android:textSize="@dimen/login_text_size"
- android:textStyle="normal|bold" />
+ android:src="@drawable/myexlogo"
--- End diff --
@Hiteshgautam01 I wonder that this image might be small on large devices like android tablet. Can you please do a quick check that this looks good at the too large or too small devices?
---
[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
Posted by Hiteshgautam01 <gi...@git.apache.org>.
Github user Hiteshgautam01 commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/71#discussion_r177643966
--- Diff: app/src/main/assets/apache_licence_notice.html ---
@@ -229,6 +229,8 @@
Apache Taverna Mobile
Copyright 2015-2018 The Apache Software Foundation
+1.Disclaimer: myExperiment's Logo is nothing to do with Apache and is copyright to myExperiment.
--- End diff --
I have done the changes.
---