You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/03/30 13:32:00 UTC
[jira] [Commented] (DRILL-8417) Allow Excel Reader to Ignore Formula Errors
[ https://issues.apache.org/jira/browse/DRILL-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706895#comment-17706895 ]
ASF GitHub Bot commented on DRILL-8417:
---------------------------------------
cgivre opened a new pull request, #2783:
URL: https://github.com/apache/drill/pull/2783
# [DRILL-8417](https://issues.apache.org/jira/browse/DRILL-8417): Allow Excel Reader to Ignore Formula Errors
## Description
If Drill encounters an Excel formula which is invalid somehow, such as a `DIV/0`, Drill is unable to proceed and throws a number format exception.
This PR adds a config parameter called `ignoreErrors` which allows Drill to skip such records and returns `null` for that cell. Drill will also output a log warning. When set to `false`, original behavior is retained.
## Documentation
Updated README
* `ignoreErrors`: Defaults to `true`. When set to `true` Drill will return `null` for any
formulas or any values that are unparseable.
## Testing
Added two unit tests.
> Allow Excel Reader to Ignore Formula Errors
> -------------------------------------------
>
> Key: DRILL-8417
> URL: https://issues.apache.org/jira/browse/DRILL-8417
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Excel
> Affects Versions: 1.21.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.21.1
>
>
> If Drill encounters an Excel formula which is invalid somehow, such as a DIV/0, Drill is unable to proceed and throws a number format exception.
> This PR adds a config parameter called ignoreErrors which allows Drill to skip such records and returns null for that cell. Drill will also output a log warning. When set to false, original behavior is retained.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)