You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/08 08:40:54 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #7193: function to read compacted topics

sijie commented on a change in pull request #7193:
URL: https://github.com/apache/pulsar/pull/7193#discussion_r436539808



##########
File path: pulsar-functions/proto/src/main/proto/Function.proto
##########
@@ -94,6 +94,7 @@ message ConsumerSpec {
         int32 value = 1;
     }
     ReceiverQueueSize receiverQueueSize = 4;
+    bool readCompacted = 5;

Review comment:
       I think a more generic approach is to add a `Map<String, String>` to the consumer spec. So we can use https://github.com/apache/pulsar/blob/870a637b4906862a611e418341dd926e21458f08/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBuilderImpl.java#L86 to load the consumer configuration when building the consumers.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org