You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/19 11:52:12 UTC
[GitHub] [apisix] nic-chen opened a new issue #3610: discuss: `batch-processor` should not depend on plugin `prometheus`
nic-chen opened a new issue #3610:
URL: https://github.com/apache/apisix/issues/3610
### Issue description
[`batch-processor`](https://github.com/apache/apisix/blob/master/apisix/utils/batch-processor.lua#L155) as the underlying lib should not depend on the upper plugin, what's your opinion? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3610: discuss: `batch-processor` should not depend on plugin `prometheus`
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #3610:
URL: https://github.com/apache/apisix/issues/3610#issuecomment-782518273
@nic-chen Would you like to paste some code snippets?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3610: discuss: `batch-processor` should not depend on plugin `prometheus`
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #3610:
URL: https://github.com/apache/apisix/issues/3610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3610: discuss: `batch-processor` should not depend on plugin `prometheus`
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #3610:
URL: https://github.com/apache/apisix/issues/3610#issuecomment-986217446
The batch processor depends on prometheus exporter, not the prometheus plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3610: discuss: `batch-processor` should not depend on plugin `prometheus`
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #3610:
URL: https://github.com/apache/apisix/issues/3610#issuecomment-782615559
Got it, should refactor it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on issue #3610: discuss: `batch-processor` should not depend on plugin `prometheus`
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #3610:
URL: https://github.com/apache/apisix/issues/3610#issuecomment-782581605
> @nic-chen Would you like to paste some code snippets?
updated. thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org