You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/01 16:01:24 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1170: include/nuttx/video/video.h: Move global variable definition out of header file

xiaoxiang781216 commented on a change in pull request #1170:
URL: https://github.com/apache/incubator-nuttx/pull/1170#discussion_r433332874



##########
File path: boards/arm/cxd56xx/spresense/src/cxd56_bringup.c
##########
@@ -139,6 +139,14 @@
  #endif
 #endif
 
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+#ifdef CONFIG_VIDEO_ISX012
+FAR const struct video_devops_s *g_video_devops;

Review comment:
       should we put it to a common location?
   drivers/video/video.c
   It's very strange that the common code reference a symbole which is defined in board specific file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org