[GitHub] [thrift] fishy commented on a diff in pull request #2700: THRIFT-5650: add uuid support in go (part I - library)

[GitBox <gi...@apache.org>]

fishy commented on code in PR #2700:
URL: https://github.com/apache/thrift/pull/2700#discussion_r990798103


##########
lib/go/thrift/uuid.go:
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package thrift
+
+import (
+	"encoding/hex"
+	"errors"
+)
+
+// most of the code is copied from https://github.com/google/uuid in order to reduce dependency on
+// external libraries

Review Comment:
   if we are copying code then the license notification would need to be different to reflect the code we copied.
   
   I really did not intend to copy any code. the majority of the complexity in uuid third party libraries are in the generating part, which we don't need in thrift, and that's why I prefer to **reimplement** the parts we need in thrift over depending on a third party library. do you need this merged in urgently? do you mind me taking this ticket later this week instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org