You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cloudstack.apache.org by "jbampton (via GitHub)" <gi...@apache.org> on 2026/02/24 14:08:04 UTC
[PR] feat: add dark mode toggle [cloudstack-www]
jbampton opened a new pull request, #406:
URL: https://github.com/apache/cloudstack-www/pull/406
This is my quick attempt at adding dark mode to our website.
With the help of Gemini. Some screen shots below:
<img width="3706" height="2007" alt="Screenshot from 2026-02-24 23-59-17" src="https://github.com/user-attachments/assets/8cf308ac-a748-4de6-8f6f-adeb5ada886d" />
<img width="3706" height="2007" alt="Screenshot from 2026-02-25 00-00-28" src="https://github.com/user-attachments/assets/9009b95c-c0eb-4e6f-a5e2-d7d9921ab0f6" />
<img width="3706" height="2007" alt="Screenshot from 2026-02-24 23-59-40" src="https://github.com/user-attachments/assets/24da7b98-434f-47e4-9a77-95d3357aa548" />
<img width="3706" height="2007" alt="Screenshot from 2026-02-24 23-59-28" src="https://github.com/user-attachments/assets/96d7161d-c58e-4009-abdd-abfcb8f583ab" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add dark mode toggle [cloudstack-www]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #406:
URL: https://github.com/apache/cloudstack-www/pull/406#issuecomment-4154059105
Personally I prefer dark mode for pages and I always have it on by default on my system.
There are a few things which might need fixing in the UI for dark mode. e.g. images needs to have a transparent background instead of white.
I propose that we do this:
1. Add the toggle on the website. But keep the dark mode disabled by default.
2. Fix whatever we need to do from UI/UX perspective.
3. Once everything is ready, we can change the setting to pick the system settings as a default. So, if you have selected "Dark Style" at OS level, the website will show up in Dark Mode. Otherwise it will show up in light mode.
(Browsers expose the system settings to the website which then toggles the dark mode automatically).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add dark mode toggle [cloudstack-www]
Posted by "yadvr (via GitHub)" <gi...@apache.org>.
yadvr commented on PR #406:
URL: https://github.com/apache/cloudstack-www/pull/406#issuecomment-4213596751
Most modern websites, ideally, should automatically detect and render dark/light mode based on OS preference. Many sites do this for accessibility (many people have eye issues, wherein a dark mode may be more comfortable for them).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add dark mode toggle [cloudstack-www]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #406:
URL: https://github.com/apache/cloudstack-www/pull/406#discussion_r3077863134
##########
docusaurus.config.js:
##########
@@ -276,7 +276,8 @@ Foundation.
},
colorMode: {
defaultMode: 'light',
- disableSwitch: true,
+ disableSwitch: false, // Changed from true to false
+ respectPrefersColorScheme: true,
Review Comment:
```suggestion
respectPrefersColorScheme: false,
```
@jbampton Let's keep it disabled for now. We can enable it later once we have polished other components which might require a change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add dark mode toggle [cloudstack-www]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #406:
URL: https://github.com/apache/cloudstack-www/pull/406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add dark mode toggle [cloudstack-www]
Posted by "IvetPM (via GitHub)" <gi...@apache.org>.
IvetPM commented on PR #406:
URL: https://github.com/apache/cloudstack-www/pull/406#issuecomment-3957617001
Hey,
Good initiative to put some thinking around the website. My question would be why we actually need this?
It is a project website, it is not a personal dashboard or software, so a user can decide how it will look.
My opinion is against this for several reasons:
- The choice of colours is important for the overall UX and website usability. This is a project website, not a software solution.
- Better readability for technical content – Dark text on a white background is easier to read.
- Stronger usability & UX – Clearer hierarchy, better link visibility, improved scannability, and reduced eye strain enhance overall user experience.
- The white version supports Google’s ranking priorities – Google rewards readability, accessibility, engagement, and structured content. Light themes better support these usability signals.
- Improved accessibility & standards compliance – Easier to meet WCAG contrast requirements and modern web accessibility standards.
This is my view. I will be happy to hear more opinions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add dark mode toggle [cloudstack-www]
Posted by "yadvr (via GitHub)" <gi...@apache.org>.
yadvr commented on PR #406:
URL: https://github.com/apache/cloudstack-www/pull/406#issuecomment-4213609555
@DaanHoogland is there a way PR can create some kind of test/QA build for reviewers to see? (just wondering, if not leave it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add dark mode toggle [cloudstack-www]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #406:
URL: https://github.com/apache/cloudstack-www/pull/406#issuecomment-4214092902
@yadvr , we have staging for that, otherwise you can build locally and preview.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add dark mode toggle [cloudstack-www]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #406:
URL: https://github.com/apache/cloudstack-www/pull/406#issuecomment-4574667133
@vishesh92 @jbampton , will you continue with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add dark mode toggle [cloudstack-www]
Posted by "wido (via GitHub)" <gi...@apache.org>.
wido commented on PR #406:
URL: https://github.com/apache/cloudstack-www/pull/406#issuecomment-5523309668
I don't have a strong opinion. I don't like dark modes, but that is personal. If people want it, I'm not against it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org