You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mark Hindess <ma...@googlemail.com> on 2007/10/23 15:11:28 UTC
Re: svn commit: r587472 - in /harmony/enhanced/drlvm/trunk: build/make/components/vm/ vm/em/build/ vm/gc_cc/build/ vm/gc_gen/build/ vm/include/open/ vm/interpreter/build/ vm/jitrino/build/ vm/vmcore/build/ vm/vmcore/include/
Please can we try to keep formatting changes separate from functional
changes? It is impossible to see from this commit message what changed
in the file because every line changed:
harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_cc.xml
In reality the real change was only one line:
--- build/make/components/vm/gc_gen.xml (revision 587471)
+++ build/make/components/vm/gc_gen.xml (revision 587472)
@@ -103,6 +103,7 @@
<libset libs="${vm.hythr.lib}" dir="${vm.hythr.libdir}" />
<select os="lnx">
<linkerarg value="-Bsymbolic" />
+ <linkerarg value="--version-script=${build.vm.home}/gc_gen/build/gc_gen.exp" />
</select>
</linker>
Thanks,
Mark.
On 23 October 2007 at 12:17, gshimansky@apache.org wrote:
> Author: gshimansky
> Date: Tue Oct 23 05:17:42 2007
> New Revision: 587472
>
> URL: http://svn.apache.org/viewvc?rev=587472&view=rev
> Log:
> Fixed bug HARMONY-4978
> [drlvm][build][EUT] Eclipse3.3 crashes on SLES10 x86
>
> Implemented version scripts for DRLVM libraries so that they export only
> necessary symbols.
>
>
> Added:
> harmony/enhanced/drlvm/trunk/vm/em/build/em.exp
> harmony/enhanced/drlvm/trunk/vm/gc_cc/build/gc_cc.exp
> harmony/enhanced/drlvm/trunk/vm/gc_gen/build/
> harmony/enhanced/drlvm/trunk/vm/gc_gen/build/gc_gen.exp
> harmony/enhanced/drlvm/trunk/vm/interpreter/build/interpreter.exp
> harmony/enhanced/drlvm/trunk/vm/jitrino/build/
> harmony/enhanced/drlvm/trunk/vm/jitrino/build/jitrino.exp
> harmony/enhanced/drlvm/trunk/vm/vmcore/build/vmcore.exp
> Modified:
> harmony/enhanced/drlvm/trunk/build/make/components/vm/em.xml
> harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_cc.xml (conten
> ts, props changed)
> harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_gen.xml (conte
> nts, props changed)
> harmony/enhanced/drlvm/trunk/build/make/components/vm/interpreter.xml
> harmony/enhanced/drlvm/trunk/build/make/components/vm/jitrino.xml
> harmony/enhanced/drlvm/trunk/build/make/components/vm/vmcore.xml
> harmony/enhanced/drlvm/trunk/vm/include/open/vm_util.h
> harmony/enhanced/drlvm/trunk/vm/vmcore/include/ini.h
>
> [ snip ]
Re: svn commit: r587472 - in /harmony/enhanced/drlvm/trunk: build/make/components/vm/ vm/em/build/ vm/gc_cc/build/ vm/gc_gen/build/ vm/include/open/ vm/interpreter/build/ vm/jitrino/build/ vm/vmcore/build/ vm/vmcore/include/
Posted by Mark Hindess <ma...@googlemail.com>.
No problem. These things happen to everyone.
Thanks,
Mark.
On 24 October 2007 at 8:04, "Weldon Washburn" <we...@gmail.com> wrote:
> Mark,
> My apologies. The config file on my laptop has been fixed. (The eol
> mods must have been lost in a recent replacement of the hard disk.)
> Weldon
>
> On 10/23/07, Mark Hindess <ma...@googlemail.com> wrote:
> >
> > On 23 October 2007 at 17:42, Gregory Shimansky <gs...@apache.org> wrot
> e:
> > > Mark Hindess wrote:
> > > > Please can we try to keep formatting changes separate from functional
> > > > changes? It is impossible to see from this commit message what changed
> > > > in the file because every line changed:
> > >
> > > Yes it happened because I set svn:eol-style property on the file that
> > > was in DOS encoding. I should have committed it in two steps.
> >
> > Thanks Gregory.
> >
> > Of course, this makes me wonder why the property was not set when it was
> > checked in by Weldon. The recommended auto-props configuration should
> > have done this already.
> >
> > Weldon: Please double-check that you have auto-props set up as described
> > in the new committer blurb - specifically the last paragraph of the
> > "Committer Subversion Access" section at:
> >
> > http://www.apache.org/dev/version-control.html#https-svn
> >
> > Incidentally, I acquired the more useful diff with the command:
> >
> > svn diff --diff-cmd diff -x "-ubwdE" -c 587472
> >
> > Regards,
> > Mark.
> >
> > > > harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_cc.xml
> > > >
> > > > In reality the real change was only one line:
> > > >
> > > > --- build/make/components/vm/gc_gen.xml (revision 587471)
> > > > +++ build/make/components/vm/gc_gen.xml (revision 587472)
> > > > @@ -103,6 +103,7 @@
> > > > <libset libs="${vm.hythr.lib}" dir="${vm.hythr.libdir}" />
> > > > <select os="lnx">
> > > > <linkerarg value="-Bsymbolic" />
> > > > + <linkerarg value="--version-script=${build.vm.home}/gc
> _gen
> > > /build/gc_gen.exp" />
> > > > </select>
> > > > </linker>
> > > >
> > > >
> > > >
> > > > Thanks,
> > > > Mark.
> > > >
> > > > On 23 October 2007 at 12:17, gshimansky@apache.org wrote:
> > > >> Author: gshimansky
> > > >> Date: Tue Oct 23 05:17:42 2007
> > > >> New Revision: 587472
> > > >>
> > > >> URL: http://svn.apache.org/viewvc?rev=587472&view=rev
> > > >> Log:
> > > >> Fixed bug HARMONY-4978
> > > >> [drlvm][build][EUT] Eclipse3.3 crashes on SLES10 x86
> > > >>
> > > >> Implemented version scripts for DRLVM libraries so that they export on
> ly
> > > >> necessary symbols.
> > > >>
> > > >>
> > > >> Added:
> > > >> harmony/enhanced/drlvm/trunk/vm/em/build/em.exp
> > > >> harmony/enhanced/drlvm/trunk/vm/gc_cc/build/gc_cc.exp
> > > >> harmony/enhanced/drlvm/trunk/vm/gc_gen/build/
> > > >> harmony/enhanced/drlvm/trunk/vm/gc_gen/build/gc_gen.exp
> > > >> harmony/enhanced/drlvm/trunk/vm/interpreter/build/interpreter.exp
> > > >> harmony/enhanced/drlvm/trunk/vm/jitrino/build/
> > > >> harmony/enhanced/drlvm/trunk/vm/jitrino/build/jitrino.exp
> > > >> harmony/enhanced/drlvm/trunk/vm/vmcore/build/vmcore.exp
> > > >> Modified:
> > > >> harmony/enhanced/drlvm/trunk/build/make/components/vm/em.xml
> > > >> harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_cc.xml
> (con
> > > ten
> > > >> ts, props changed)
> > > >> harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_gen.xml
> (co
> > > nte
> > > >> nts, props changed)
> > > >> harmony/enhanced/drlvm/trunk/build/make/components/vm/interpreter.
> xml
> > > >> harmony/enhanced/drlvm/trunk/build/make/components/vm/jitrino.xml
> > > >> harmony/enhanced/drlvm/trunk/build/make/components/vm/vmcore.xml
> > > >> harmony/enhanced/drlvm/trunk/vm/include/open/vm_util.h
> > > >> harmony/enhanced/drlvm/trunk/vm/vmcore/include/ini.h
> > > >>
> > > >> [ snip ]
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > Gregory
> > >
> >
> >
> >
>
>
> --
> Weldon Washburn
>
Re: svn commit: r587472 - in /harmony/enhanced/drlvm/trunk: build/make/components/vm/ vm/em/build/ vm/gc_cc/build/ vm/gc_gen/build/ vm/include/open/ vm/interpreter/build/ vm/jitrino/build/ vm/vmcore/build/ vm/vmcore/include/
Posted by Weldon Washburn <we...@gmail.com>.
Mark,
My apologies. The config file on my laptop has been fixed. (The eol
mods must have been lost in a recent replacement of the hard disk.)
Weldon
On 10/23/07, Mark Hindess <ma...@googlemail.com> wrote:
>
> On 23 October 2007 at 17:42, Gregory Shimansky <gs...@apache.org> wrote:
> > Mark Hindess wrote:
> > > Please can we try to keep formatting changes separate from functional
> > > changes? It is impossible to see from this commit message what changed
> > > in the file because every line changed:
> >
> > Yes it happened because I set svn:eol-style property on the file that
> > was in DOS encoding. I should have committed it in two steps.
>
> Thanks Gregory.
>
> Of course, this makes me wonder why the property was not set when it was
> checked in by Weldon. The recommended auto-props configuration should
> have done this already.
>
> Weldon: Please double-check that you have auto-props set up as described
> in the new committer blurb - specifically the last paragraph of the
> "Committer Subversion Access" section at:
>
> http://www.apache.org/dev/version-control.html#https-svn
>
> Incidentally, I acquired the more useful diff with the command:
>
> svn diff --diff-cmd diff -x "-ubwdE" -c 587472
>
> Regards,
> Mark.
>
> > > harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_cc.xml
> > >
> > > In reality the real change was only one line:
> > >
> > > --- build/make/components/vm/gc_gen.xml (revision 587471)
> > > +++ build/make/components/vm/gc_gen.xml (revision 587472)
> > > @@ -103,6 +103,7 @@
> > > <libset libs="${vm.hythr.lib}" dir="${vm.hythr.libdir}" />
> > > <select os="lnx">
> > > <linkerarg value="-Bsymbolic" />
> > > + <linkerarg value="--version-script=${build.vm.home}/gc_gen
> > /build/gc_gen.exp" />
> > > </select>
> > > </linker>
> > >
> > >
> > >
> > > Thanks,
> > > Mark.
> > >
> > > On 23 October 2007 at 12:17, gshimansky@apache.org wrote:
> > >> Author: gshimansky
> > >> Date: Tue Oct 23 05:17:42 2007
> > >> New Revision: 587472
> > >>
> > >> URL: http://svn.apache.org/viewvc?rev=587472&view=rev
> > >> Log:
> > >> Fixed bug HARMONY-4978
> > >> [drlvm][build][EUT] Eclipse3.3 crashes on SLES10 x86
> > >>
> > >> Implemented version scripts for DRLVM libraries so that they export only
> > >> necessary symbols.
> > >>
> > >>
> > >> Added:
> > >> harmony/enhanced/drlvm/trunk/vm/em/build/em.exp
> > >> harmony/enhanced/drlvm/trunk/vm/gc_cc/build/gc_cc.exp
> > >> harmony/enhanced/drlvm/trunk/vm/gc_gen/build/
> > >> harmony/enhanced/drlvm/trunk/vm/gc_gen/build/gc_gen.exp
> > >> harmony/enhanced/drlvm/trunk/vm/interpreter/build/interpreter.exp
> > >> harmony/enhanced/drlvm/trunk/vm/jitrino/build/
> > >> harmony/enhanced/drlvm/trunk/vm/jitrino/build/jitrino.exp
> > >> harmony/enhanced/drlvm/trunk/vm/vmcore/build/vmcore.exp
> > >> Modified:
> > >> harmony/enhanced/drlvm/trunk/build/make/components/vm/em.xml
> > >> harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_cc.xml (con
> > ten
> > >> ts, props changed)
> > >> harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_gen.xml (co
> > nte
> > >> nts, props changed)
> > >> harmony/enhanced/drlvm/trunk/build/make/components/vm/interpreter.xml
> > >> harmony/enhanced/drlvm/trunk/build/make/components/vm/jitrino.xml
> > >> harmony/enhanced/drlvm/trunk/build/make/components/vm/vmcore.xml
> > >> harmony/enhanced/drlvm/trunk/vm/include/open/vm_util.h
> > >> harmony/enhanced/drlvm/trunk/vm/vmcore/include/ini.h
> > >>
> > >> [ snip ]
> > >
> > >
> > >
> >
> >
> > --
> > Gregory
> >
>
>
>
--
Weldon Washburn
Re: svn commit: r587472 - in /harmony/enhanced/drlvm/trunk: build/make/components/vm/ vm/em/build/ vm/gc_cc/build/ vm/gc_gen/build/ vm/include/open/ vm/interpreter/build/ vm/jitrino/build/ vm/vmcore/build/ vm/vmcore/include/
Posted by Mark Hindess <ma...@googlemail.com>.
On 23 October 2007 at 17:42, Gregory Shimansky <gs...@apache.org> wrote:
> Mark Hindess wrote:
> > Please can we try to keep formatting changes separate from functional
> > changes? It is impossible to see from this commit message what changed
> > in the file because every line changed:
>
> Yes it happened because I set svn:eol-style property on the file that
> was in DOS encoding. I should have committed it in two steps.
Thanks Gregory.
Of course, this makes me wonder why the property was not set when it was
checked in by Weldon. The recommended auto-props configuration should
have done this already.
Weldon: Please double-check that you have auto-props set up as described
in the new committer blurb - specifically the last paragraph of the
"Committer Subversion Access" section at:
http://www.apache.org/dev/version-control.html#https-svn
Incidentally, I acquired the more useful diff with the command:
svn diff --diff-cmd diff -x "-ubwdE" -c 587472
Regards,
Mark.
> > harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_cc.xml
> >
> > In reality the real change was only one line:
> >
> > --- build/make/components/vm/gc_gen.xml (revision 587471)
> > +++ build/make/components/vm/gc_gen.xml (revision 587472)
> > @@ -103,6 +103,7 @@
> > <libset libs="${vm.hythr.lib}" dir="${vm.hythr.libdir}" />
> > <select os="lnx">
> > <linkerarg value="-Bsymbolic" />
> > + <linkerarg value="--version-script=${build.vm.home}/gc_gen
> /build/gc_gen.exp" />
> > </select>
> > </linker>
> >
> >
> >
> > Thanks,
> > Mark.
> >
> > On 23 October 2007 at 12:17, gshimansky@apache.org wrote:
> >> Author: gshimansky
> >> Date: Tue Oct 23 05:17:42 2007
> >> New Revision: 587472
> >>
> >> URL: http://svn.apache.org/viewvc?rev=587472&view=rev
> >> Log:
> >> Fixed bug HARMONY-4978
> >> [drlvm][build][EUT] Eclipse3.3 crashes on SLES10 x86
> >>
> >> Implemented version scripts for DRLVM libraries so that they export only
> >> necessary symbols.
> >>
> >>
> >> Added:
> >> harmony/enhanced/drlvm/trunk/vm/em/build/em.exp
> >> harmony/enhanced/drlvm/trunk/vm/gc_cc/build/gc_cc.exp
> >> harmony/enhanced/drlvm/trunk/vm/gc_gen/build/
> >> harmony/enhanced/drlvm/trunk/vm/gc_gen/build/gc_gen.exp
> >> harmony/enhanced/drlvm/trunk/vm/interpreter/build/interpreter.exp
> >> harmony/enhanced/drlvm/trunk/vm/jitrino/build/
> >> harmony/enhanced/drlvm/trunk/vm/jitrino/build/jitrino.exp
> >> harmony/enhanced/drlvm/trunk/vm/vmcore/build/vmcore.exp
> >> Modified:
> >> harmony/enhanced/drlvm/trunk/build/make/components/vm/em.xml
> >> harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_cc.xml (con
> ten
> >> ts, props changed)
> >> harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_gen.xml (co
> nte
> >> nts, props changed)
> >> harmony/enhanced/drlvm/trunk/build/make/components/vm/interpreter.xml
> >> harmony/enhanced/drlvm/trunk/build/make/components/vm/jitrino.xml
> >> harmony/enhanced/drlvm/trunk/build/make/components/vm/vmcore.xml
> >> harmony/enhanced/drlvm/trunk/vm/include/open/vm_util.h
> >> harmony/enhanced/drlvm/trunk/vm/vmcore/include/ini.h
> >>
> >> [ snip ]
> >
> >
> >
>
>
> --
> Gregory
>
Re: svn commit: r587472 - in /harmony/enhanced/drlvm/trunk: build/make/components/vm/
vm/em/build/ vm/gc_cc/build/ vm/gc_gen/build/ vm/include/open/ vm/interpreter/build/
vm/jitrino/build/ vm/vmcore/build/ vm/vmcore/include/
Posted by Gregory Shimansky <gs...@apache.org>.
Mark Hindess wrote:
> Please can we try to keep formatting changes separate from functional
> changes? It is impossible to see from this commit message what changed
> in the file because every line changed:
Yes it happened because I set svn:eol-style property on the file that
was in DOS encoding. I should have committed it in two steps.
> harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_cc.xml
>
> In reality the real change was only one line:
>
> --- build/make/components/vm/gc_gen.xml (revision 587471)
> +++ build/make/components/vm/gc_gen.xml (revision 587472)
> @@ -103,6 +103,7 @@
> <libset libs="${vm.hythr.lib}" dir="${vm.hythr.libdir}" />
> <select os="lnx">
> <linkerarg value="-Bsymbolic" />
> + <linkerarg value="--version-script=${build.vm.home}/gc_gen/build/gc_gen.exp" />
> </select>
> </linker>
>
>
>
> Thanks,
> Mark.
>
> On 23 October 2007 at 12:17, gshimansky@apache.org wrote:
>> Author: gshimansky
>> Date: Tue Oct 23 05:17:42 2007
>> New Revision: 587472
>>
>> URL: http://svn.apache.org/viewvc?rev=587472&view=rev
>> Log:
>> Fixed bug HARMONY-4978
>> [drlvm][build][EUT] Eclipse3.3 crashes on SLES10 x86
>>
>> Implemented version scripts for DRLVM libraries so that they export only
>> necessary symbols.
>>
>>
>> Added:
>> harmony/enhanced/drlvm/trunk/vm/em/build/em.exp
>> harmony/enhanced/drlvm/trunk/vm/gc_cc/build/gc_cc.exp
>> harmony/enhanced/drlvm/trunk/vm/gc_gen/build/
>> harmony/enhanced/drlvm/trunk/vm/gc_gen/build/gc_gen.exp
>> harmony/enhanced/drlvm/trunk/vm/interpreter/build/interpreter.exp
>> harmony/enhanced/drlvm/trunk/vm/jitrino/build/
>> harmony/enhanced/drlvm/trunk/vm/jitrino/build/jitrino.exp
>> harmony/enhanced/drlvm/trunk/vm/vmcore/build/vmcore.exp
>> Modified:
>> harmony/enhanced/drlvm/trunk/build/make/components/vm/em.xml
>> harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_cc.xml (conten
>> ts, props changed)
>> harmony/enhanced/drlvm/trunk/build/make/components/vm/gc_gen.xml (conte
>> nts, props changed)
>> harmony/enhanced/drlvm/trunk/build/make/components/vm/interpreter.xml
>> harmony/enhanced/drlvm/trunk/build/make/components/vm/jitrino.xml
>> harmony/enhanced/drlvm/trunk/build/make/components/vm/vmcore.xml
>> harmony/enhanced/drlvm/trunk/vm/include/open/vm_util.h
>> harmony/enhanced/drlvm/trunk/vm/vmcore/include/ini.h
>>
>> [ snip ]
>
>
>
--
Gregory