You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2026/07/14 21:02:15 UTC
[PR] Allow multiple routes to show active NavButtons [airflow]
bbovenzi opened a new pull request, #69884:
URL: https://github.com/apache/airflow/pull/69884
Update NavButton to show isActive for multiple routes. Such as all the children of menu buttons like Browse, Plugins and Admin. Or for Dags to stay active with the dag runs and task instance table pages.
<img width="359" height="387" alt="Screenshot 2026-07-14 at 4 57 20 PM" src="https://github.com/user-attachments/assets/b3a6e26e-e7ea-49c1-9942-34b674af113a" />
<img width="430" height="416" alt="Screenshot 2026-07-14 at 4 57 12 PM" src="https://github.com/user-attachments/assets/b0e8afbd-4bc0-454a-ba93-52e21be35d34" />
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] Yes Claude Sonnet 5
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow multiple routes to show active NavButtons [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #69884:
URL: https://github.com/apache/airflow/pull/69884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow multiple routes to show active NavButtons [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69884:
URL: https://github.com/apache/airflow/pull/69884#issuecomment-5037297784
### Backport successfully created: v3-3-test
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-3-test</td>
<td><a href="https://github.com/apache/airflow/pull/70200"><img src="https://img.shields.io/badge/PR-70200-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow multiple routes to show active NavButtons [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #69884:
URL: https://github.com/apache/airflow/pull/69884#discussion_r3615086623
##########
airflow-core/src/airflow/ui/src/layouts/Nav/SecurityButton.tsx:
##########
@@ -33,10 +33,14 @@ export const SecurityButton = () => {
return undefined;
}
+ const securityPaths = authLinks.extra_menu_items.map(
+ ({ text }) => `security/${text.toLowerCase().replace(" ", "-")}`,
Review Comment:
Tiny thing: the security/<slug> derivation is now in two spots (here and the securityKey below that builds the link). Might be worth computing the slug once so the active-match can't drift from where the item actually links. Non-blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org