You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/25 19:13:45 UTC

[GitHub] [kafka] ryannedolan commented on a change in pull request #10402: TRIVIAL: Minor improvements

ryannedolan commented on a change in pull request #10402:
URL: https://github.com/apache/kafka/pull/10402#discussion_r601772795



##########
File path: connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/RemoteClusterUtils.java
##########
@@ -1,94 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.kafka.connect.mirror;
-
-import org.apache.kafka.common.TopicPartition;
-import org.apache.kafka.clients.consumer.OffsetAndMetadata;
-
-import java.util.Map;
-import java.util.Set;
-import java.util.concurrent.TimeoutException;
-import java.time.Duration;
-
-
-/** Convenience methods for multi-cluster environments. Wraps MirrorClient (@see MirrorClient).
- *  <p>
- *  Properties passed to these methods are used to construct internal Admin and Consumer clients.
- *  Sub-configs like "admin.xyz" are also supported. For example:
- *  </p>
- *  <pre>
- *      bootstrap.servers = host1:9092
- *      consumer.client.id = mm2-client
- *  </pre>
- *  <p>
- *  @see MirrorClientConfig for additional properties used by the internal MirrorClient.
- *  </p>
- */
-public final class RemoteClusterUtils {

Review comment:
       This is a public interface and js definitely being used in external projects.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org