You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/06 03:45:48 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #18189: Rename ApmPluginLoader to AgentPluginLoader.
RaigorJiang opened a new pull request, #18189:
URL: https://github.com/apache/shardingsphere/pull/18189
In the agent, the plugin loader is responsible for loading plugins resources.
Now, the plugin loader has only one implementation: `ApmPluginLoader`.
It actually loads all plugins, including metrics, tracing, logging, etc., and prints logs when the Proxy starts:
````
[main] o.a.s.a.core.plugin.ApmPluginLoader - Loaded jar shardingsphere-agent-metrics-prometheus-5.1.2-SNAPSHOT.jar
[main] o.a.s.a.core.plugin.ApmPluginLoader - Loaded jar shardingsphere-agent-tracing-zipkin-5.1.2-SNAPSHOT.jar
[main] o.a.s.a.core.plugin.ApmPluginLoader - Loaded jar shardingsphere-agent-tracing-opentracing-5.1.2-SNAPSHOT.jar
[main] o.a.s.a.core.plugin.ApmPluginLoader - Loaded jar shardingsphere-agent-tracing-jaeger-5.1.2-SNAPSHOT.jar
[main] o.a.s.a.core.plugin.ApmPluginLoader - Loaded jar shardingsphere-agent-tracing-opentelemetry-5.1.2-SNAPSHOT.jar
[main] o.a.s.a.core.plugin.ApmPluginLoader - Loaded jar shardingsphere-agent-logging-base-5.1.2-SNAPSHOT.jar
[main] o.a.s.a.core.plugin.ApmPluginLoader - Load plugin: Logging
````
I think `Apm` might confuse users, so it would be better to call `AgentPluginLoader`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #18189: Rename ApmPluginLoader to AgentPluginLoader.
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #18189:
URL: https://github.com/apache/shardingsphere/pull/18189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18189: Rename ApmPluginLoader to AgentPluginLoader.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18189:
URL: https://github.com/apache/shardingsphere/pull/18189#issuecomment-1147106856
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18189?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18189](https://codecov.io/gh/apache/shardingsphere/pull/18189?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f2ca937) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7f5c97dc28a4b9689080624fb1eb77432ac05e8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f5c97d) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #18189 +/- ##
=========================================
Coverage 59.20% 59.20%
Complexity 2180 2180
=========================================
Files 3711 3711
Lines 54518 54518
Branches 9261 9261
=========================================
Hits 32280 32280
Misses 19491 19491
Partials 2747 2747
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ingsphere/agent/bootstrap/ShardingSphereAgent.java](https://codecov.io/gh/apache/shardingsphere/pull/18189/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvU2hhcmRpbmdTcGhlcmVBZ2VudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ingsphere/agent/core/plugin/AgentPluginLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/18189/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vQWdlbnRQbHVnaW5Mb2FkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rdingsphere/agent/core/spi/AgentServiceLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/18189/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9zcGkvQWdlbnRTZXJ2aWNlTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...dingsphere/agent/core/spi/PluginServiceLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/18189/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9zcGkvUGx1Z2luU2VydmljZUxvYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18189?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18189?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0b29187...f2ca937](https://codecov.io/gh/apache/shardingsphere/pull/18189?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org