You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/25 05:58:32 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #21806: Rename `dagrun_id` to `dag_run_id`

uranusjr commented on a change in pull request #21806:
URL: https://github.com/apache/airflow/pull/21806#discussion_r814495413



##########
File path: airflow/migrations/versions/c306b5b5ae4a_switch_xcom_table_to_use_run_id.py
##########
@@ -41,7 +41,7 @@
 
 def _get_new_xcom_columns() -> Sequence[Column]:
     return [
-        Column("dagrun_id", Integer(), nullable=False),
+        Column("dag_run_id", Integer(), nullable=False),

Review comment:
       IMO `dagrun_id` is more appropriate here because it refers to the `id` column on the `dagrun` table.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org