You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/23 17:15:01 UTC
[GitHub] [geode] onichols-pivotal opened a new pull request #7031: GEODE-9767: Bump netty from 4.1.67.Final to 4.1.69.Final
onichols-pivotal opened a new pull request #7031:
URL: https://github.com/apache/geode/pull/7031
Netty decided to repackage their netty-all-bom as 36 separate jars instead of one big jar in 4.1.69. This might be a good opportunity to review which one(s) Geode actually needs, rather than exploding our jar count upwards by three dozen, so keeping this in Draft while investigating that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7031: GEODE-9767: Bump netty from 4.1.67.Final to 4.1.69.Final
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #7031:
URL: https://github.com/apache/geode/pull/7031#discussion_r735756242
##########
File path: geode-for-redis/src/test/resources/expected-pom.xml
##########
@@ -83,7 +83,12 @@
</dependency>
<dependency>
<groupId>io.netty</groupId>
- <artifactId>netty-all</artifactId>
+ <artifactId>netty-codec-redis</artifactId>
+ <scope>runtime</scope>
Review comment:
The scope could just be `test`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal merged pull request #7031: GEODE-9767: Bump netty from 4.1.67.Final to 4.1.69.Final
Posted by GitBox <gi...@apache.org>.
onichols-pivotal merged pull request #7031:
URL: https://github.com/apache/geode/pull/7031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #7031: GEODE-9767: Bump netty from 4.1.67.Final to 4.1.69.Final
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #7031:
URL: https://github.com/apache/geode/pull/7031#discussion_r735790559
##########
File path: geode-for-redis/src/test/resources/expected-pom.xml
##########
@@ -83,7 +83,12 @@
</dependency>
<dependency>
<groupId>io.netty</groupId>
- <artifactId>netty-all</artifactId>
+ <artifactId>netty-codec-redis</artifactId>
+ <scope>runtime</scope>
Review comment:
good call, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on a change in pull request #7031: GEODE-9767: Bump netty from 4.1.67.Final to 4.1.69.Final
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on a change in pull request #7031:
URL: https://github.com/apache/geode/pull/7031#discussion_r736823119
##########
File path: geode-for-redis/build.gradle
##########
@@ -79,6 +80,7 @@ dependencies {
acceptanceTestImplementation(project(':geode-junit'))
acceptanceTestImplementation('redis.clients:jedis')
acceptanceTestImplementation('org.testcontainers:testcontainers')
+ acceptanceTestRuntimeOnly('io.netty:netty-codec-redis')
Review comment:
We shouldn't need this, since `acceptanceTest` extends `commonTest`
##########
File path: geode-for-redis/build.gradle
##########
@@ -92,6 +94,7 @@ dependencies {
acceptanceTestImplementation('io.lettuce:lettuce-core')
acceptanceTestRuntimeOnly('io.lettuce:lettuce-core')
+ distributedTestRuntimeOnly('io.netty:netty-codec-redis')
Review comment:
We shouldn't need this, since `distributedTest` extends `commonTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7031: GEODE-9767: Bump netty from 4.1.67.Final to 4.1.69.Final
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #7031:
URL: https://github.com/apache/geode/pull/7031#discussion_r735756242
##########
File path: geode-for-redis/src/test/resources/expected-pom.xml
##########
@@ -83,7 +83,12 @@
</dependency>
<dependency>
<groupId>io.netty</groupId>
- <artifactId>netty-all</artifactId>
+ <artifactId>netty-codec-redis</artifactId>
+ <scope>runtime</scope>
Review comment:
This could just be `test`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org