svn commit: r801371 - /james/jsieve/trunk/main/src/main/java/org/apache/jsieve/commands/Discard.java

[rd...@apache.org]

Author: rdonkin
Date: Wed Aug  5 19:22:47 2009
New Revision: 801371

URL: http://svn.apache.org/viewvc?rev=801371&view=rev
Log:
JSIEVE-62 Improve readability by explicitly setting implicit keep. This is already called in the super class but it's more readable here. https://issues.apache.org/jira/browse/JSIEVE-62

Modified:
    james/jsieve/trunk/main/src/main/java/org/apache/jsieve/commands/Discard.java

Modified: james/jsieve/trunk/main/src/main/java/org/apache/jsieve/commands/Discard.java
URL: http://svn.apache.org/viewvc/james/jsieve/trunk/main/src/main/java/org/apache/jsieve/commands/Discard.java?rev=801371&r1=801370&r2=801371&view=diff
==============================================================================
--- james/jsieve/trunk/main/src/main/java/org/apache/jsieve/commands/Discard.java (original)
+++ james/jsieve/trunk/main/src/main/java/org/apache/jsieve/commands/Discard.java Wed Aug  5 19:22:47 2009
@@ -51,8 +51,9 @@
      */
     protected Object executeBasic(MailAdapter mail, Arguments arguments,
             Block block, SieveContext context) throws SieveException {
-        // TODO: check whether discard works without the line below
-        // mail.addAction(new ActionDiscard());
+        // Just cancels the implicit keep
+        // See http://tools.ietf.org/html/rfc5228#section-4.4
+        context.getCommandStateManager().setImplicitKeep(false);
         return null;
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org