You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by me...@apache.org on 2025/04/05 12:11:37 UTC

(opendal) branch fix-set-user-metadata created (now 40043c386)

This is an automated email from the ASF dual-hosted git repository.

meteorgan pushed a change to branch fix-set-user-metadata
in repository https://gitbox.apache.org/repos/asf/opendal.git


      at 40043c386 chore(core/types): rename with_user_metadata to set_user_metadata to maintain consistency with other methods in the metadata

This branch includes the following new commits:

     new 40043c386 chore(core/types): rename with_user_metadata to set_user_metadata to maintain consistency with other methods in the metadata

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(opendal) 01/01: chore(core/types): rename with_user_metadata to set_user_metadata to maintain consistency with other methods in the metadata

Posted by me...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

meteorgan pushed a commit to branch fix-set-user-metadata
in repository https://gitbox.apache.org/repos/asf/opendal.git

commit 40043c3862783adc276e2301641499b97beca883
Author: meteorgan <me...@gmail.com>
AuthorDate: Sat Apr 5 20:11:05 2025 +0800

    chore(core/types): rename with_user_metadata to set_user_metadata to maintain consistency with other methods in the metadata
---
 core/src/services/azblob/backend.rs | 2 +-
 core/src/services/cos/backend.rs    | 2 +-
 core/src/services/gcs/core.rs       | 2 +-
 core/src/services/obs/backend.rs    | 2 +-
 core/src/services/oss/core.rs       | 2 +-
 core/src/services/s3/backend.rs     | 2 +-
 core/src/services/swift/backend.rs  | 2 +-
 core/src/types/metadata.rs          | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/core/src/services/azblob/backend.rs b/core/src/services/azblob/backend.rs
index eafe32ddb..7eff589ef 100644
--- a/core/src/services/azblob/backend.rs
+++ b/core/src/services/azblob/backend.rs
@@ -570,7 +570,7 @@ impl Access for AzblobBackend {
 
                 let user_meta = parse_prefixed_headers(headers, X_MS_META_PREFIX);
                 if !user_meta.is_empty() {
-                    meta.with_user_metadata(user_meta);
+                    meta.set_user_metadata(user_meta);
                 }
 
                 Ok(RpStat::new(meta))
diff --git a/core/src/services/cos/backend.rs b/core/src/services/cos/backend.rs
index 854a8a33a..0862b1e5c 100644
--- a/core/src/services/cos/backend.rs
+++ b/core/src/services/cos/backend.rs
@@ -339,7 +339,7 @@ impl Access for CosBackend {
 
                 let user_meta = parse_prefixed_headers(headers, "x-cos-meta-");
                 if !user_meta.is_empty() {
-                    meta.with_user_metadata(user_meta);
+                    meta.set_user_metadata(user_meta);
                 }
 
                 if let Some(v) = parse_header_to_str(headers, constants::X_COS_VERSION_ID)? {
diff --git a/core/src/services/gcs/core.rs b/core/src/services/gcs/core.rs
index d85c48fa5..22faa9fc6 100644
--- a/core/src/services/gcs/core.rs
+++ b/core/src/services/gcs/core.rs
@@ -684,7 +684,7 @@ impl GcsCore {
         m.set_last_modified(parse_datetime_from_rfc3339(&meta.updated)?);
 
         if !meta.metadata.is_empty() {
-            m.with_user_metadata(meta.metadata);
+            m.set_user_metadata(meta.metadata);
         }
 
         Ok(m)
diff --git a/core/src/services/obs/backend.rs b/core/src/services/obs/backend.rs
index 748e37d41..bf94d8e7c 100644
--- a/core/src/services/obs/backend.rs
+++ b/core/src/services/obs/backend.rs
@@ -354,7 +354,7 @@ impl Access for ObsBackend {
                     .collect::<HashMap<_, _>>();
 
                 if !user_meta.is_empty() {
-                    meta.with_user_metadata(user_meta);
+                    meta.set_user_metadata(user_meta);
                 }
 
                 if let Some(v) = parse_header_to_str(headers, constants::X_OBS_VERSION_ID)? {
diff --git a/core/src/services/oss/core.rs b/core/src/services/oss/core.rs
index c88d4806e..ebdec66b3 100644
--- a/core/src/services/oss/core.rs
+++ b/core/src/services/oss/core.rs
@@ -239,7 +239,7 @@ impl OssCore {
         let mut m = parse_into_metadata(path, headers)?;
         let user_meta = parse_prefixed_headers(headers, X_OSS_META_PREFIX);
         if !user_meta.is_empty() {
-            m.with_user_metadata(user_meta);
+            m.set_user_metadata(user_meta);
         }
 
         Ok(m)
diff --git a/core/src/services/s3/backend.rs b/core/src/services/s3/backend.rs
index 9ce15829a..9a60402da 100644
--- a/core/src/services/s3/backend.rs
+++ b/core/src/services/s3/backend.rs
@@ -1035,7 +1035,7 @@ impl Access for S3Backend {
 
                 let user_meta = parse_prefixed_headers(headers, X_AMZ_META_PREFIX);
                 if !user_meta.is_empty() {
-                    meta.with_user_metadata(user_meta);
+                    meta.set_user_metadata(user_meta);
                 }
 
                 if let Some(v) = parse_header_to_str(headers, X_AMZ_VERSION_ID)? {
diff --git a/core/src/services/swift/backend.rs b/core/src/services/swift/backend.rs
index ba8529dc3..767eaac94 100644
--- a/core/src/services/swift/backend.rs
+++ b/core/src/services/swift/backend.rs
@@ -229,7 +229,7 @@ impl Access for SwiftBackend {
                 let mut meta = parse_into_metadata(path, headers)?;
                 let user_meta = parse_prefixed_headers(headers, "x-object-meta-");
                 if !user_meta.is_empty() {
-                    meta.with_user_metadata(user_meta);
+                    meta.set_user_metadata(user_meta);
                 }
 
                 Ok(RpStat::new(meta))
diff --git a/core/src/types/metadata.rs b/core/src/types/metadata.rs
index 0508f1988..7a19968a5 100644
--- a/core/src/types/metadata.rs
+++ b/core/src/types/metadata.rs
@@ -429,7 +429,7 @@ impl Metadata {
     }
 
     /// Set user defined metadata of this entry
-    pub fn with_user_metadata(&mut self, data: HashMap<String, String>) -> &mut Self {
+    pub fn set_user_metadata(&mut self, data: HashMap<String, String>) -> &mut Self {
         self.user_metadata = Some(data);
         self
     }