[jira] [Work logged] (HDFS-15492) Make trash root inside each snapshottable directory

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-15492?focusedWorklogId=475926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475926 ]

ASF GitHub Bot logged work on HDFS-15492:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Aug/20 17:50
            Start Date: 28/Aug/20 17:50
    Worklog Time Spent: 10m 
      Work Description: jojochuang commented on pull request #2176:
URL: https://github.com/apache/hadoop/pull/2176#issuecomment-682989066


   I'm late to this. But we should verify to make sure httpfs also behaves the sames. Otherwise it'll break Hue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 475926)
    Remaining Estimate: 0h
            Time Spent: 10m

> Make trash root inside each snapshottable directory
> ---------------------------------------------------
>
>                 Key: HDFS-15492
>                 URL: https://issues.apache.org/jira/browse/HDFS-15492
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs, hdfs-client
>    Affects Versions: 3.2.1
>            Reporter: Siyao Meng
>            Assignee: Siyao Meng
>            Priority: Major
>             Fix For: 3.4.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We have seen FSImage corruption cases (e.g. HDFS-13101) where files inside one snapshottable directories are moved outside of it. The most common case of this is when trash is enabled and user deletes some file via the command line without skipTrash.
> This jira aims to make a trash root for each snapshottable directory, same as how encryption zone behaves at the moment.
> This will make trash cleanup a little bit more expensive on the NameNode as it will be to iterate all trash roots. But should be fine as long as there aren't many snapshottable directories.
> I could make this improvement as an option and disable it by default if needed, such as {{dfs.namenode.snapshot.trashroot.enabled}}
> One small caveat though, when disabling (disallowing) snapshot on the snapshottable directory when this improvement is in place. The client should merge the snapshottable directory's trash with that user's trash to ensure proper trash cleanup.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org