You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "Baunsgaard (via GitHub)" <gi...@apache.org> on 2024/12/29 20:11:00 UTC
[PR] [MINOR] reformat releaseIntern in cacheableData [systemds]
Baunsgaard opened a new pull request, #2167:
URL: https://github.com/apache/systemds/pull/2167
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] reformat releaseIntern in cacheableData [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2167:
URL: https://github.com/apache/systemds/pull/2167#issuecomment-2564837133
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2167?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `58.33333%` with `5 lines` in your changes missing coverage. Please review.
> Project coverage is 72.28%. Comparing base [(`96fd5da`)](https://app.codecov.io/gh/apache/systemds/commit/96fd5da49e4f936c378f11cc275c34ff5f8a84d1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b5b2ac1`)](https://app.codecov.io/gh/apache/systemds/commit/b5b2ac1ea4807e0667c6ae68b2541af735a42433?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/systemds/pull/2167?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../runtime/controlprogram/caching/CacheableData.java](https://app.codecov.io/gh/apache/systemds/pull/2167?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcontrolprogram%2Fcaching%2FCacheableData.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29udHJvbHByb2dyYW0vY2FjaGluZy9DYWNoZWFibGVEYXRhLmphdmE=) | 58.33% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2167 +/- ##
============================================
- Coverage 72.29% 72.28% -0.01%
+ Complexity 44248 44247 -1
============================================
Files 1443 1443
Lines 166603 166603
Branches 32537 32537
============================================
- Hits 120441 120429 -12
- Misses 36920 36928 +8
- Partials 9242 9246 +4
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/systemds/pull/2167?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] reformat releaseIntern in cacheableData [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #2167:
URL: https://github.com/apache/systemds/pull/2167#issuecomment-2564828358
Perhaps this change is not needed. I remember a problem in some edge case that prompted me to make this change, but I do not remember what. Therefore, this change is separated from BWARE and perhaps not to be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org