You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/09/13 15:36:23 UTC

[GitHub] [beam] Abacn opened a new pull request, #28434: Revert "Fix flaky test StreamingDataflowWorkerTest"

Abacn opened a new pull request, #28434:
URL: https://github.com/apache/beam/pull/28434

   Reverts apache/beam#28173
   
   The enabled test has been flaky on both Jenkins and actions. e,g, https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/7319/testReport/junit/org.apache.beam.runners.dataflow.worker/StreamingDataflowWorkerTest/testMaxThreadMetric_0___streamingEngine_false__/
   
   ```
   Stacktrace
   java.lang.AssertionError: expected:<1000> but was:<0>
   	at org.junit.Assert.fail(Assert.java:89)
   	at org.junit.Assert.failNotEquals(Assert.java:835)
   	at org.junit.Assert.assertEquals(Assert.java:647)
   	at org.junit.Assert.assertEquals(Assert.java:633)
   	at org.apache.beam.runners.dataflow.worker.StreamingDataflowWorkerTest.testMaxThreadMetric(StreamingDataflowWorkerTest.java:2935)
   	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn merged pull request #28434: Revert "Fix flaky test StreamingDataflowWorkerTest"

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #28434:
URL: https://github.com/apache/beam/pull/28434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on pull request #28434: Revert "Fix flaky test StreamingDataflowWorkerTest"

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #28434:
URL: https://github.com/apache/beam/pull/28434#issuecomment-1718192066

   LGTM, thanks. Sorry about the noise it caused.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #28434: Revert "Fix flaky test StreamingDataflowWorkerTest"

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28434:
URL: https://github.com/apache/beam/pull/28434#issuecomment-1717878407

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #28434: Revert "Fix flaky test StreamingDataflowWorkerTest"

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #28434:
URL: https://github.com/apache/beam/pull/28434#issuecomment-1717875812

   R: @tvalentyn 
   CC: @olalamichelle thanks willing to dig into this in the original PR. The branch hash is stay so we can always come back and investigate. For now I would propose this change to de-noise purpose 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #28434: Revert "Fix flaky test StreamingDataflowWorkerTest"

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #28434:
URL: https://github.com/apache/beam/pull/28434#issuecomment-1718278586

   Ironically the PreCommit GitHub Action still fails this test even it's reverted in this PR: https://github.com/apache/beam/actions/runs/6174695355/job/16759856184?pr=28434
   
   ```
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org