You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by David E Jones <de...@me.com> on 2010/01/13 07:07:57 UTC
Screen Widget screenlet and the hard coded br class="clear"
I am looking into an issue with formatting using a CSS-based multiple column layout and with screenlets in each column.
The problem is that in the htmlScreenMacroLibrary.ftl file there is a hard-coded clear on line 148:
<br class="clear" />
With most browsers these clears are no context-sensitive, they clear ALL floats. This means that it messes up the multi-column formatting.
Would anyone be too disappointed if we removed this, and if you need a clear below your screenlet then just use a container element after the screenlet element in your screen definition?
Also, does anyone know the reason this was put there in the first place?
Can anyone think of any issues removing this might cause?
-David
Re: Screen Widget screenlet and the hard coded br class="clear"
Posted by Adrian Crum <ad...@yahoo.com>.
Something to think about - and this is beyond the scope of your question - is that someday we will need to change how screen widgets are rendered.
Right now model widgets are rendered directly to an output stream. It would be preferable to have the model widgets rendered to an intermediate Java structure that is passed to a layout manager. The layout manager makes the kind of decisions discussed here (and in other threads) then it outputs the markup to the output stream.
-Adrian
--- On Tue, 1/12/10, Adrian Crum <ad...@yahoo.com> wrote:
> From: Adrian Crum <ad...@yahoo.com>
> Subject: Re: Screen Widget screenlet and the hard coded br class="clear"
> To: dev@ofbiz.apache.org
> Date: Tuesday, January 12, 2010, 10:55 PM
> No, we need the column container and
> column widgets so the renderers know when to output clearing
> elements and when not to.
>
> You're not going to solve the problem with CSS alone. The
> markup has to reflect what you're trying to accomplish.
>
> What you're describing is a tug-of-war that has been going
> on as far back as I can remember. It started with adding
> multi-column elements to the GlobalDecorator (a bad idea)
> and has continued on to today. There is a fundamental flaw
> in how multi-column layout is handled, and it needs to be
> fixed. Until then we have to be satisfied with kludges like
> the no-clear CSS class.
>
> -Adrian
>
>
> --- On Tue, 1/12/10, David E Jones <de...@me.com>
> wrote:
>
> > From: David E Jones <de...@me.com>
> > Subject: Re: Screen Widget screenlet and the hard
> coded br class="clear"
> > To: dev@ofbiz.apache.org
> > Date: Tuesday, January 12, 2010, 10:35 PM
> >
> > I guess what you mean by this is as part of that
> larger
> > effort you'll have to introduce a new CSS pattern for
> > multi-column layouts.
> >
> > Do we really need a column widget in order to use a
> better
> > CSS pattern for the multi-column layout?
> >
> > -David
> >
> >
> > On Jan 13, 2010, at 12:28 AM, Adrian Crum wrote:
> >
> > > I disagree. The stuff we have doesn't work just
> fine.
> > Try removing the clearing element and see what
> happens. The
> > multi-column layout you're working on looks great, but
> now
> > everything else is broken.
> > >
> > > Our existing multi-column layout is extremely
> fragile
> > and easily broken. That's why I suggested the column
> > widgets. It's a bigger issue than dragging columns or
> > changing sizes.
> > >
> > > -Adrian
> > >
> > > --- On Tue, 1/12/10, David E Jones <de...@me.com>
> > wrote:
> > >
> > >> From: David E Jones <de...@me.com>
> > >> Subject: Re: Screen Widget screenlet and the
> hard
> > coded br class="clear"
> > >> To: dev@ofbiz.apache.org
> > >> Date: Tuesday, January 12, 2010, 10:20 PM
> > >>
> > >> The point isn't to accommodate multi-column
> > layouts, we
> > >> already have basic stuff for that which works
> just
> > fine. I'm
> > >> not talking about anything like dragging
> columns
> > or
> > >> configuring sizes or anything like that. It's
> an
> > interesting
> > >> idea, but a different one.
> > >>
> > >> The question I have is do we really want
> this
> > <br
> > >> class="clear"/> tag always inserted when
> you
> > use the
> > >> screen widget screenlet element?
> > >>
> > >> Right now there is a bit of a "hack" in place
> to
> > cause this
> > >> tag to do nothing, and that is by wrapping
> the
> > screenlet in
> > >> a container with a style of "no-clear".
> > >>
> > >> So, the point is that is seems like in most
> cases
> > this
> > >> clear isn't needed and we can avoid the
> no-clear
> > hack by
> > >> having something explicit when it is needed.
> > >>
> > >> -David
> > >>
> > >>
> > >> On Jan 13, 2010, at 12:13 AM, Adrian Crum
> wrote:
> > >>
> > >>> We had a discussion about accommodating
> > multi-column
> > >> layouts. Search the dev list for Subject =
> > "Discussion:
> > >> Column Widgets (was: How to add a splitter
> to
> > adjust the
> > >> left column width by dragging it?"
> > >>>
> > >>> -Adrian
> > >>>
> > >>> --- On Tue, 1/12/10, David E Jones <de...@me.com>
> > >> wrote:
> > >>>
> > >>>> From: David E Jones <de...@me.com>
> > >>>> Subject: Screen Widget screenlet and
> the
> > hard
> > >> coded br class="clear"
> > >>>> To: dev@ofbiz.apache.org
> > >>>> Date: Tuesday, January 12, 2010,
> 10:07 PM
> > >>>>
> > >>>> I am looking into an issue with
> formatting
> > using
> > >> a
> > >>>> CSS-based multiple column layout and
> with
> > >> screenlets in each
> > >>>> column.
> > >>>>
> > >>>> The problem is that in the
> > >> htmlScreenMacroLibrary.ftl file
> > >>>> there is a hard-coded clear on line
> 148:
> > >>>>
> > >>>> <br class="clear" />
> > >>>>
> > >>>> With most browsers these clears are
> no
> > >> context-sensitive,
> > >>>> they clear ALL floats. This means
> that it
> > messes
> > >> up the
> > >>>> multi-column formatting.
> > >>>>
> > >>>> Would anyone be too disappointed if
> we
> > removed
> > >> this, and if
> > >>>> you need a clear below your screenlet
> then
> > just
> > >> use a
> > >>>> container element after the
> screenlet
> > element in
> > >> your screen
> > >>>> definition?
> > >>>>
> > >>>> Also, does anyone know the reason
> this was
> > put
> > >> there in the
> > >>>> first place?
> > >>>>
> > >>>> Can anyone think of any issues
> removing
> > this might
> > >> cause?
> > >>>>
> > >>>> -David
> > >>>>
> > >>>>
> > >>>>
> > >>>
> > >>>
> > >>>
> > >>
> > >>
> > >
> > >
> > >
> >
> >
>
>
>
>
Re: Screen Widget screenlet and the hard coded br class="clear"
Posted by Adrian Crum <ad...@yahoo.com>.
No, we need the column container and column widgets so the renderers know when to output clearing elements and when not to.
You're not going to solve the problem with CSS alone. The markup has to reflect what you're trying to accomplish.
What you're describing is a tug-of-war that has been going on as far back as I can remember. It started with adding multi-column elements to the GlobalDecorator (a bad idea) and has continued on to today. There is a fundamental flaw in how multi-column layout is handled, and it needs to be fixed. Until then we have to be satisfied with kludges like the no-clear CSS class.
-Adrian
--- On Tue, 1/12/10, David E Jones <de...@me.com> wrote:
> From: David E Jones <de...@me.com>
> Subject: Re: Screen Widget screenlet and the hard coded br class="clear"
> To: dev@ofbiz.apache.org
> Date: Tuesday, January 12, 2010, 10:35 PM
>
> I guess what you mean by this is as part of that larger
> effort you'll have to introduce a new CSS pattern for
> multi-column layouts.
>
> Do we really need a column widget in order to use a better
> CSS pattern for the multi-column layout?
>
> -David
>
>
> On Jan 13, 2010, at 12:28 AM, Adrian Crum wrote:
>
> > I disagree. The stuff we have doesn't work just fine.
> Try removing the clearing element and see what happens. The
> multi-column layout you're working on looks great, but now
> everything else is broken.
> >
> > Our existing multi-column layout is extremely fragile
> and easily broken. That's why I suggested the column
> widgets. It's a bigger issue than dragging columns or
> changing sizes.
> >
> > -Adrian
> >
> > --- On Tue, 1/12/10, David E Jones <de...@me.com>
> wrote:
> >
> >> From: David E Jones <de...@me.com>
> >> Subject: Re: Screen Widget screenlet and the hard
> coded br class="clear"
> >> To: dev@ofbiz.apache.org
> >> Date: Tuesday, January 12, 2010, 10:20 PM
> >>
> >> The point isn't to accommodate multi-column
> layouts, we
> >> already have basic stuff for that which works just
> fine. I'm
> >> not talking about anything like dragging columns
> or
> >> configuring sizes or anything like that. It's an
> interesting
> >> idea, but a different one.
> >>
> >> The question I have is do we really want this
> <br
> >> class="clear"/> tag always inserted when you
> use the
> >> screen widget screenlet element?
> >>
> >> Right now there is a bit of a "hack" in place to
> cause this
> >> tag to do nothing, and that is by wrapping the
> screenlet in
> >> a container with a style of "no-clear".
> >>
> >> So, the point is that is seems like in most cases
> this
> >> clear isn't needed and we can avoid the no-clear
> hack by
> >> having something explicit when it is needed.
> >>
> >> -David
> >>
> >>
> >> On Jan 13, 2010, at 12:13 AM, Adrian Crum wrote:
> >>
> >>> We had a discussion about accommodating
> multi-column
> >> layouts. Search the dev list for Subject =
> "Discussion:
> >> Column Widgets (was: How to add a splitter to
> adjust the
> >> left column width by dragging it?"
> >>>
> >>> -Adrian
> >>>
> >>> --- On Tue, 1/12/10, David E Jones <de...@me.com>
> >> wrote:
> >>>
> >>>> From: David E Jones <de...@me.com>
> >>>> Subject: Screen Widget screenlet and the
> hard
> >> coded br class="clear"
> >>>> To: dev@ofbiz.apache.org
> >>>> Date: Tuesday, January 12, 2010, 10:07 PM
> >>>>
> >>>> I am looking into an issue with formatting
> using
> >> a
> >>>> CSS-based multiple column layout and with
> >> screenlets in each
> >>>> column.
> >>>>
> >>>> The problem is that in the
> >> htmlScreenMacroLibrary.ftl file
> >>>> there is a hard-coded clear on line 148:
> >>>>
> >>>> <br class="clear" />
> >>>>
> >>>> With most browsers these clears are no
> >> context-sensitive,
> >>>> they clear ALL floats. This means that it
> messes
> >> up the
> >>>> multi-column formatting.
> >>>>
> >>>> Would anyone be too disappointed if we
> removed
> >> this, and if
> >>>> you need a clear below your screenlet then
> just
> >> use a
> >>>> container element after the screenlet
> element in
> >> your screen
> >>>> definition?
> >>>>
> >>>> Also, does anyone know the reason this was
> put
> >> there in the
> >>>> first place?
> >>>>
> >>>> Can anyone think of any issues removing
> this might
> >> cause?
> >>>>
> >>>> -David
> >>>>
> >>>>
> >>>>
> >>>
> >>>
> >>>
> >>
> >>
> >
> >
> >
>
>
Re: Screen Widget screenlet and the hard coded br class="clear"
Posted by David E Jones <de...@me.com>.
I guess what you mean by this is as part of that larger effort you'll have to introduce a new CSS pattern for multi-column layouts.
Do we really need a column widget in order to use a better CSS pattern for the multi-column layout?
-David
On Jan 13, 2010, at 12:28 AM, Adrian Crum wrote:
> I disagree. The stuff we have doesn't work just fine. Try removing the clearing element and see what happens. The multi-column layout you're working on looks great, but now everything else is broken.
>
> Our existing multi-column layout is extremely fragile and easily broken. That's why I suggested the column widgets. It's a bigger issue than dragging columns or changing sizes.
>
> -Adrian
>
> --- On Tue, 1/12/10, David E Jones <de...@me.com> wrote:
>
>> From: David E Jones <de...@me.com>
>> Subject: Re: Screen Widget screenlet and the hard coded br class="clear"
>> To: dev@ofbiz.apache.org
>> Date: Tuesday, January 12, 2010, 10:20 PM
>>
>> The point isn't to accommodate multi-column layouts, we
>> already have basic stuff for that which works just fine. I'm
>> not talking about anything like dragging columns or
>> configuring sizes or anything like that. It's an interesting
>> idea, but a different one.
>>
>> The question I have is do we really want this <br
>> class="clear"/> tag always inserted when you use the
>> screen widget screenlet element?
>>
>> Right now there is a bit of a "hack" in place to cause this
>> tag to do nothing, and that is by wrapping the screenlet in
>> a container with a style of "no-clear".
>>
>> So, the point is that is seems like in most cases this
>> clear isn't needed and we can avoid the no-clear hack by
>> having something explicit when it is needed.
>>
>> -David
>>
>>
>> On Jan 13, 2010, at 12:13 AM, Adrian Crum wrote:
>>
>>> We had a discussion about accommodating multi-column
>> layouts. Search the dev list for Subject = "Discussion:
>> Column Widgets (was: How to add a splitter to adjust the
>> left column width by dragging it?"
>>>
>>> -Adrian
>>>
>>> --- On Tue, 1/12/10, David E Jones <de...@me.com>
>> wrote:
>>>
>>>> From: David E Jones <de...@me.com>
>>>> Subject: Screen Widget screenlet and the hard
>> coded br class="clear"
>>>> To: dev@ofbiz.apache.org
>>>> Date: Tuesday, January 12, 2010, 10:07 PM
>>>>
>>>> I am looking into an issue with formatting using
>> a
>>>> CSS-based multiple column layout and with
>> screenlets in each
>>>> column.
>>>>
>>>> The problem is that in the
>> htmlScreenMacroLibrary.ftl file
>>>> there is a hard-coded clear on line 148:
>>>>
>>>> <br class="clear" />
>>>>
>>>> With most browsers these clears are no
>> context-sensitive,
>>>> they clear ALL floats. This means that it messes
>> up the
>>>> multi-column formatting.
>>>>
>>>> Would anyone be too disappointed if we removed
>> this, and if
>>>> you need a clear below your screenlet then just
>> use a
>>>> container element after the screenlet element in
>> your screen
>>>> definition?
>>>>
>>>> Also, does anyone know the reason this was put
>> there in the
>>>> first place?
>>>>
>>>> Can anyone think of any issues removing this might
>> cause?
>>>>
>>>> -David
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>
>>
>
>
>
Re: Screen Widget screenlet and the hard coded br class="clear"
Posted by Adrian Crum <ad...@hlmksw.com>.
Please don't apologize for chiming in - we need everyone to participate
in the discussion.
Maybe you could create a list of suggestions and the rest of the
community can work on implementing them.
-Adrian
Ryan Foster wrote:
> I think that is kind of the point Adrian. Many screens are fragile because they have been hacked together with <br> tags, inline styles, etc, not in spite of that fact. We should remove these everywhere they are found and replace them with proper markup that is more stable and more flexible. You can just as easily clear the floated element with the element underneath or use any number CSS solutions that will make the element clear itself without any additional empty tags. In the Bizznesstime Theme, this is already built in. If you want an element to clear itself, just give it a clear name of "clearfix". At the very least, we should replace the <br> tag with a <div> tag. At least then we are using better markup. Line breaks should be used in text, as they are intended, not for layout.
>
> Sorry for the soapbox, but as the lone wolf front-end developer on this list sometimes, I feel like I need to speak up when there is something I feel strongly about.
>
> Ryan Foster
> HotWax Media
> 801.671.0769
> ryan.foster@hotwaxmedia.com
>
>
>
>
> On Jan 12, 2010, at 11:28 PM, Adrian Crum wrote:
>
>> I disagree. The stuff we have doesn't work just fine. Try removing the clearing element and see what happens. The multi-column layout you're working on looks great, but now everything else is broken.
>>
>> Our existing multi-column layout is extremely fragile and easily broken. That's why I suggested the column widgets. It's a bigger issue than dragging columns or changing sizes.
>>
>> -Adrian
>>
>> --- On Tue, 1/12/10, David E Jones <de...@me.com> wrote:
>>
>>> From: David E Jones <de...@me.com>
>>> Subject: Re: Screen Widget screenlet and the hard coded br class="clear"
>>> To: dev@ofbiz.apache.org
>>> Date: Tuesday, January 12, 2010, 10:20 PM
>>>
>>> The point isn't to accommodate multi-column layouts, we
>>> already have basic stuff for that which works just fine. I'm
>>> not talking about anything like dragging columns or
>>> configuring sizes or anything like that. It's an interesting
>>> idea, but a different one.
>>>
>>> The question I have is do we really want this <br
>>> class="clear"/> tag always inserted when you use the
>>> screen widget screenlet element?
>>>
>>> Right now there is a bit of a "hack" in place to cause this
>>> tag to do nothing, and that is by wrapping the screenlet in
>>> a container with a style of "no-clear".
>>>
>>> So, the point is that is seems like in most cases this
>>> clear isn't needed and we can avoid the no-clear hack by
>>> having something explicit when it is needed.
>>>
>>> -David
>>>
>>>
>>> On Jan 13, 2010, at 12:13 AM, Adrian Crum wrote:
>>>
>>>> We had a discussion about accommodating multi-column
>>> layouts. Search the dev list for Subject = "Discussion:
>>> Column Widgets (was: How to add a splitter to adjust the
>>> left column width by dragging it?"
>>>> -Adrian
>>>>
>>>> --- On Tue, 1/12/10, David E Jones <de...@me.com>
>>> wrote:
>>>>> From: David E Jones <de...@me.com>
>>>>> Subject: Screen Widget screenlet and the hard
>>> coded br class="clear"
>>>>> To: dev@ofbiz.apache.org
>>>>> Date: Tuesday, January 12, 2010, 10:07 PM
>>>>>
>>>>> I am looking into an issue with formatting using
>>> a
>>>>> CSS-based multiple column layout and with
>>> screenlets in each
>>>>> column.
>>>>>
>>>>> The problem is that in the
>>> htmlScreenMacroLibrary.ftl file
>>>>> there is a hard-coded clear on line 148:
>>>>>
>>>>> <br class="clear" />
>>>>>
>>>>> With most browsers these clears are no
>>> context-sensitive,
>>>>> they clear ALL floats. This means that it messes
>>> up the
>>>>> multi-column formatting.
>>>>>
>>>>> Would anyone be too disappointed if we removed
>>> this, and if
>>>>> you need a clear below your screenlet then just
>>> use a
>>>>> container element after the screenlet element in
>>> your screen
>>>>> definition?
>>>>>
>>>>> Also, does anyone know the reason this was put
>>> there in the
>>>>> first place?
>>>>>
>>>>> Can anyone think of any issues removing this might
>>> cause?
>>>>> -David
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>
>
Re: Screen Widget screenlet and the hard coded br class="clear"
Posted by Ryan Foster <ry...@hotwaxmedia.com>.
I think that is kind of the point Adrian. Many screens are fragile because they have been hacked together with <br> tags, inline styles, etc, not in spite of that fact. We should remove these everywhere they are found and replace them with proper markup that is more stable and more flexible. You can just as easily clear the floated element with the element underneath or use any number CSS solutions that will make the element clear itself without any additional empty tags. In the Bizznesstime Theme, this is already built in. If you want an element to clear itself, just give it a clear name of "clearfix". At the very least, we should replace the <br> tag with a <div> tag. At least then we are using better markup. Line breaks should be used in text, as they are intended, not for layout.
Sorry for the soapbox, but as the lone wolf front-end developer on this list sometimes, I feel like I need to speak up when there is something I feel strongly about.
Ryan Foster
HotWax Media
801.671.0769
ryan.foster@hotwaxmedia.com
On Jan 12, 2010, at 11:28 PM, Adrian Crum wrote:
> I disagree. The stuff we have doesn't work just fine. Try removing the clearing element and see what happens. The multi-column layout you're working on looks great, but now everything else is broken.
>
> Our existing multi-column layout is extremely fragile and easily broken. That's why I suggested the column widgets. It's a bigger issue than dragging columns or changing sizes.
>
> -Adrian
>
> --- On Tue, 1/12/10, David E Jones <de...@me.com> wrote:
>
>> From: David E Jones <de...@me.com>
>> Subject: Re: Screen Widget screenlet and the hard coded br class="clear"
>> To: dev@ofbiz.apache.org
>> Date: Tuesday, January 12, 2010, 10:20 PM
>>
>> The point isn't to accommodate multi-column layouts, we
>> already have basic stuff for that which works just fine. I'm
>> not talking about anything like dragging columns or
>> configuring sizes or anything like that. It's an interesting
>> idea, but a different one.
>>
>> The question I have is do we really want this <br
>> class="clear"/> tag always inserted when you use the
>> screen widget screenlet element?
>>
>> Right now there is a bit of a "hack" in place to cause this
>> tag to do nothing, and that is by wrapping the screenlet in
>> a container with a style of "no-clear".
>>
>> So, the point is that is seems like in most cases this
>> clear isn't needed and we can avoid the no-clear hack by
>> having something explicit when it is needed.
>>
>> -David
>>
>>
>> On Jan 13, 2010, at 12:13 AM, Adrian Crum wrote:
>>
>>> We had a discussion about accommodating multi-column
>> layouts. Search the dev list for Subject = "Discussion:
>> Column Widgets (was: How to add a splitter to adjust the
>> left column width by dragging it?"
>>>
>>> -Adrian
>>>
>>> --- On Tue, 1/12/10, David E Jones <de...@me.com>
>> wrote:
>>>
>>>> From: David E Jones <de...@me.com>
>>>> Subject: Screen Widget screenlet and the hard
>> coded br class="clear"
>>>> To: dev@ofbiz.apache.org
>>>> Date: Tuesday, January 12, 2010, 10:07 PM
>>>>
>>>> I am looking into an issue with formatting using
>> a
>>>> CSS-based multiple column layout and with
>> screenlets in each
>>>> column.
>>>>
>>>> The problem is that in the
>> htmlScreenMacroLibrary.ftl file
>>>> there is a hard-coded clear on line 148:
>>>>
>>>> <br class="clear" />
>>>>
>>>> With most browsers these clears are no
>> context-sensitive,
>>>> they clear ALL floats. This means that it messes
>> up the
>>>> multi-column formatting.
>>>>
>>>> Would anyone be too disappointed if we removed
>> this, and if
>>>> you need a clear below your screenlet then just
>> use a
>>>> container element after the screenlet element in
>> your screen
>>>> definition?
>>>>
>>>> Also, does anyone know the reason this was put
>> there in the
>>>> first place?
>>>>
>>>> Can anyone think of any issues removing this might
>> cause?
>>>>
>>>> -David
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>
>>
>
>
>
Re: Screen Widget screenlet and the hard coded br class="clear"
Posted by Adrian Crum <ad...@yahoo.com>.
I disagree. The stuff we have doesn't work just fine. Try removing the clearing element and see what happens. The multi-column layout you're working on looks great, but now everything else is broken.
Our existing multi-column layout is extremely fragile and easily broken. That's why I suggested the column widgets. It's a bigger issue than dragging columns or changing sizes.
-Adrian
--- On Tue, 1/12/10, David E Jones <de...@me.com> wrote:
> From: David E Jones <de...@me.com>
> Subject: Re: Screen Widget screenlet and the hard coded br class="clear"
> To: dev@ofbiz.apache.org
> Date: Tuesday, January 12, 2010, 10:20 PM
>
> The point isn't to accommodate multi-column layouts, we
> already have basic stuff for that which works just fine. I'm
> not talking about anything like dragging columns or
> configuring sizes or anything like that. It's an interesting
> idea, but a different one.
>
> The question I have is do we really want this <br
> class="clear"/> tag always inserted when you use the
> screen widget screenlet element?
>
> Right now there is a bit of a "hack" in place to cause this
> tag to do nothing, and that is by wrapping the screenlet in
> a container with a style of "no-clear".
>
> So, the point is that is seems like in most cases this
> clear isn't needed and we can avoid the no-clear hack by
> having something explicit when it is needed.
>
> -David
>
>
> On Jan 13, 2010, at 12:13 AM, Adrian Crum wrote:
>
> > We had a discussion about accommodating multi-column
> layouts. Search the dev list for Subject = "Discussion:
> Column Widgets (was: How to add a splitter to adjust the
> left column width by dragging it?"
> >
> > -Adrian
> >
> > --- On Tue, 1/12/10, David E Jones <de...@me.com>
> wrote:
> >
> >> From: David E Jones <de...@me.com>
> >> Subject: Screen Widget screenlet and the hard
> coded br class="clear"
> >> To: dev@ofbiz.apache.org
> >> Date: Tuesday, January 12, 2010, 10:07 PM
> >>
> >> I am looking into an issue with formatting using
> a
> >> CSS-based multiple column layout and with
> screenlets in each
> >> column.
> >>
> >> The problem is that in the
> htmlScreenMacroLibrary.ftl file
> >> there is a hard-coded clear on line 148:
> >>
> >> <br class="clear" />
> >>
> >> With most browsers these clears are no
> context-sensitive,
> >> they clear ALL floats. This means that it messes
> up the
> >> multi-column formatting.
> >>
> >> Would anyone be too disappointed if we removed
> this, and if
> >> you need a clear below your screenlet then just
> use a
> >> container element after the screenlet element in
> your screen
> >> definition?
> >>
> >> Also, does anyone know the reason this was put
> there in the
> >> first place?
> >>
> >> Can anyone think of any issues removing this might
> cause?
> >>
> >> -David
> >>
> >>
> >>
> >
> >
> >
>
>
Re: Screen Widget screenlet and the hard coded br class="clear"
Posted by David E Jones <de...@me.com>.
The point isn't to accommodate multi-column layouts, we already have basic stuff for that which works just fine. I'm not talking about anything like dragging columns or configuring sizes or anything like that. It's an interesting idea, but a different one.
The question I have is do we really want this <br class="clear"/> tag always inserted when you use the screen widget screenlet element?
Right now there is a bit of a "hack" in place to cause this tag to do nothing, and that is by wrapping the screenlet in a container with a style of "no-clear".
So, the point is that is seems like in most cases this clear isn't needed and we can avoid the no-clear hack by having something explicit when it is needed.
-David
On Jan 13, 2010, at 12:13 AM, Adrian Crum wrote:
> We had a discussion about accommodating multi-column layouts. Search the dev list for Subject = "Discussion: Column Widgets (was: How to add a splitter to adjust the left column width by dragging it?"
>
> -Adrian
>
> --- On Tue, 1/12/10, David E Jones <de...@me.com> wrote:
>
>> From: David E Jones <de...@me.com>
>> Subject: Screen Widget screenlet and the hard coded br class="clear"
>> To: dev@ofbiz.apache.org
>> Date: Tuesday, January 12, 2010, 10:07 PM
>>
>> I am looking into an issue with formatting using a
>> CSS-based multiple column layout and with screenlets in each
>> column.
>>
>> The problem is that in the htmlScreenMacroLibrary.ftl file
>> there is a hard-coded clear on line 148:
>>
>> <br class="clear" />
>>
>> With most browsers these clears are no context-sensitive,
>> they clear ALL floats. This means that it messes up the
>> multi-column formatting.
>>
>> Would anyone be too disappointed if we removed this, and if
>> you need a clear below your screenlet then just use a
>> container element after the screenlet element in your screen
>> definition?
>>
>> Also, does anyone know the reason this was put there in the
>> first place?
>>
>> Can anyone think of any issues removing this might cause?
>>
>> -David
>>
>>
>>
>
>
>
Re: Screen Widget screenlet and the hard coded br class="clear"
Posted by Adrian Crum <ad...@yahoo.com>.
We had a discussion about accommodating multi-column layouts. Search the dev list for Subject = "Discussion: Column Widgets (was: How to add a splitter to adjust the left column width by dragging it?"
-Adrian
--- On Tue, 1/12/10, David E Jones <de...@me.com> wrote:
> From: David E Jones <de...@me.com>
> Subject: Screen Widget screenlet and the hard coded br class="clear"
> To: dev@ofbiz.apache.org
> Date: Tuesday, January 12, 2010, 10:07 PM
>
> I am looking into an issue with formatting using a
> CSS-based multiple column layout and with screenlets in each
> column.
>
> The problem is that in the htmlScreenMacroLibrary.ftl file
> there is a hard-coded clear on line 148:
>
> <br class="clear" />
>
> With most browsers these clears are no context-sensitive,
> they clear ALL floats. This means that it messes up the
> multi-column formatting.
>
> Would anyone be too disappointed if we removed this, and if
> you need a clear below your screenlet then just use a
> container element after the screenlet element in your screen
> definition?
>
> Also, does anyone know the reason this was put there in the
> first place?
>
> Can anyone think of any issues removing this might cause?
>
> -David
>
>
>