You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/03/24 09:17:11 UTC

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2736: [SCB-2422]change bean injection to constructor injection

liubao68 commented on a change in pull request #2736:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2736#discussion_r834083947



##########
File path: governance/src/main/java/org/apache/servicecomb/router/distribute/AbstractRouterDistributor.java
##########
@@ -46,9 +46,16 @@
 
   private Function<E, Map<String, String>> getProperties;
 
-  @Autowired
   private RouterRuleCache routerRuleCache;
 
+  @Autowired
+  public AbstractRouterDistributor(RouterRuleCache routerRuleCache) {
+    this.routerRuleCache = routerRuleCache;
+  }
+
+  protected AbstractRouterDistributor() {
+  }

Review comment:
       change to setter injection




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org