[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5145: HDFS-16847: Prevents StateStoreFileSystemImpl from committing tmp file after encountering an IOException.

[GitBox <gi...@apache.org>]

mkuchenbecker commented on code in PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#discussion_r1028378298


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java:
##########
@@ -88,6 +88,15 @@ protected abstract <T extends BaseRecord> BufferedReader getReader(
   protected abstract <T extends BaseRecord> BufferedWriter getWriter(
       String path);
 
+  /**
+   * Convenience method to allow to mocking of protected
+   * {@link #getWriter(String)}
+   */
+  @VisibleForTesting
+  public BufferedWriter getBufferedWriter(String path) {

Review Comment:
   Private? Protected? There is no reason to have `VisibleForTesting` if public. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org