You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/09 11:06:50 UTC
[GitHub] [beam] aromanenko-dev commented on a change in pull request #14171: [BEAM-11913] Add support for Hadoop configuration on ParquetIO
aromanenko-dev commented on a change in pull request #14171:
URL: https://github.com/apache/beam/pull/14171#discussion_r590212523
##########
File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -641,11 +661,14 @@ public ReadFiles withProjection(Schema projectionSchema, Schema encoderSchema) {
/** Specify Hadoop configuration for ParquetReader. */
public ReadFiles withConfiguration(Map<String, String> configuration) {
+ checkArgument(configuration != null, "configuration can not be null");
return toBuilder().setConfiguration(SerializableConfiguration.fromMap(configuration)).build();
}
- public ReadFiles withConfiguration(SerializableConfiguration configuration) {
Review comment:
Since it's public then maybe just deprecate it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org