You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by sg...@apache.org on 2009/02/18 00:17:52 UTC
svn commit: r745289 - in
/commons/proper/exec/trunk/src/main/java/org/apache/commons/exec:
DefaultExecutor.java util/MapUtils.java
Author: sgoeschl
Date: Tue Feb 17 23:17:52 2009
New Revision: 745289
URL: http://svn.apache.org/viewvc?rev=745289&view=rev
Log:
[EXEC-35] Fixing minor findbugs issues.
Modified:
commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/DefaultExecutor.java
commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/util/MapUtils.java
Modified: commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/DefaultExecutor.java
URL: http://svn.apache.org/viewvc/commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/DefaultExecutor.java?rev=745289&r1=745288&r2=745289&view=diff
==============================================================================
--- commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/DefaultExecutor.java (original)
+++ commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/DefaultExecutor.java Tue Feb 17 23:17:52 2009
@@ -198,7 +198,7 @@
/** @see org.apache.commons.exec.Executor#setExitValues(int[]) */
public void setExitValues(final int[] values) {
- this.exitValues = values;
+ this.exitValues = (int[]) values.clone();
}
/** @see org.apache.commons.exec.Executor#isFailure(int) */
Modified: commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/util/MapUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/util/MapUtils.java?rev=745289&r1=745288&r2=745289&view=diff
==============================================================================
--- commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/util/MapUtils.java (original)
+++ commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/util/MapUtils.java Tue Feb 17 23:17:52 2009
@@ -65,11 +65,12 @@
return null;
}
- Iterator iter = source.keySet().iterator();
+ Iterator iter = source.entrySet().iterator();
while(iter.hasNext()) {
- Object key = iter.next();
- Object value = source.get(key);
+ Map.Entry entry = (Map.Entry) iter.next();
+ Object key = entry.getKey();
+ Object value = entry.getValue();
result.put(prefix + '.' + key.toString(), value);
}