[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4470: [TE] Include admin recipients in every email alert (cc address)

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #4470: [TE] Include admin recipients in every email alert (cc address)
URL: https://github.com/apache/incubator-pinot/pull/4470#discussion_r307462046
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/scheme/DetectionEmailAlerter.java
 ##########
 @@ -62,7 +63,10 @@
 
   private static final Comparator<AnomalyResult> COMPARATOR_DESC =
       (o1, o2) -> -1 * Long.compare(o1.getStartTime(), o2.getStartTime());
-  private static final String EMAIL_WHITELIST_KEY = "emailWhitelist";
+
+  private static final String PROP_EMAIL_WHITELIST = "emailWhitelist";
+  private static final String PROP_ADMIN_RECIPIENTS = "adminRecipients";
 
 Review comment:
   Well, adminRecipients are not tied with either an application or subscription group. By admin, I am referring to the platform admins (us). We need to be part of all the alerts that are sent out.
   
   For example, we include thirdeye-dev alias in cc for all the email alerts we send out. This will give us insights into which alerts are very actively monitored (email threads), which conversations ended up in critical GCNs and we can also help them with RCA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org