You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/12/03 02:38:48 UTC

[GitHub] incubator-brooklyn pull request: Fix WinRM config, and refactor wi...

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1083

    Fix WinRM config, and refactor winrm testing

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn refactor/winrm-testing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1083.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1083
    
----
commit fea59a4e18fedca16aeabdf4f395bb6f19150843
Author: Aled Sage <al...@gmail.com>
Date:   2015-12-02T23:54:09Z

    WinRM testing: refactor so can be sub-classed
    
    For testing alternative WinRmTool implementations (e.g. in downstream
    project), these changes allow WinRmMachineLocationLiveTest to be
    subclassed.

commit 17b6583bae894907eaa146b9618e52dc698dce48
Author: Aled Sage <al...@gmail.com>
Date:   2015-12-03T01:01:12Z

    WinRm machine: extract config for WinRmTool
    
    Follows same code pattern as is in SshMachineLocation.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix WinRM config, and refactor wi...

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1083#issuecomment-161541592
  
    Looks good, merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix WinRM config, and refactor wi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/1083


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---