You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/17 23:59:31 UTC
[GitHub] [superset] jinghua-qa opened a new issue #16305: [sort by][time series bart chart v2]Sort by is not working for time series bar chart v2
jinghua-qa opened a new issue #16305:
URL: https://github.com/apache/superset/issues/16305
Sort by is not working for time series bar chart v2
### Expected results
When Sort DESCENDING is select, data is return in descending
### Actual results
When Sort DESCENDING is select, data is not
#### Screenshots
<img width="1785" alt="Screen Shot 2021-08-17 at 4 54 04 PM" src="https://user-images.githubusercontent.com/81597121/129815528-349a2027-ffbb-46bf-bf20-8b7cf65d3c71.png">
<img width="1787" alt="Screen Shot 2021-08-17 at 4 54 14 PM" src="https://user-images.githubusercontent.com/81597121/129815532-c32be1f2-9426-4228-ad0e-cb2c132d1bcd.png">
return in descending
#### How to reproduce the bug
1. create a time series bar chart, select SORT BY and select Sort DESCENDING
2. observe data panel
3. See error
### Environment
(please complete the following information):
- superset version: lastest master
- python version: `python --version`
- node.js version: `node -v`
- any feature flags active:
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #16305: [sort by][time series bart chart v2]Sort by is not working for time series bar chart v2
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #16305:
URL: https://github.com/apache/superset/issues/16305#issuecomment-900805808
thanks for catching!! @villebro 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro edited a comment on issue #16305: [sort by][time series bart chart v2]Sort by is not working for time series bar chart v2
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #16305:
URL: https://github.com/apache/superset/issues/16305#issuecomment-902462165
We may need to reconsider what the expected behavior here is. AFAIK, the primary role of the sort control is to make sure that we can pick the top n series based on a certain metric (see the subquery that queries for the top 100 series based on `count` in descending order). The ordering is done correctly in the analytical database, so the data is returned in descending order based on the `count` column. However, the data in the result pane shows the data after the pivot operation, where each series is given a column of their own. We can of course resort the pivoted data, but that wouldn't change how the bars are rendered.
I propose we clarify that the sorting column in timeseries charts is meant for limiting series only, and potentially introduce a subsection which encapsulates all limit related controls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro edited a comment on issue #16305: [sort by][time series bart chart v2]Sort by is not working for time series bar chart v2
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #16305:
URL: https://github.com/apache/superset/issues/16305#issuecomment-902462165
We may need to reconsider what the expected behavior here is. AFAIK, the primary role of the sort control is to make sure that we can pick the top n series based on a certain metric (see the subquery that queries for the top 100 series based on `count` in descending order). The ordering is done correctly in the analytical database, so the data is returned in descending order based on the `count` column. However, the data in the result pane shows the data after the pivot operation which happens in the backend (after the query), where each series is given a column of their own. We can of course resort the pivoted data, but that wouldn't change how the bars are rendered.
I propose we clarify that the sorting column in timeseries charts is meant for limiting series only, and potentially introduce a subsection which encapsulates all limit related controls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #16305: [sort by][time series bart chart v2]Sort by is not working for time series bar chart v2
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #16305:
URL: https://github.com/apache/superset/issues/16305#issuecomment-902462165
We may need to reconsider what the expected behavior here is. AFAIK, the primary role of the sort control is to make sure that we can pick the top n series based on a certain metric (see the subquery that queries for the top 100 series based on `count` in descending order). The ordering is done correctly in the analytical database, so the data is returned in descending order based on the `count` column. However, the data in the result pane shows the data after the pivot operation, where each series is given a column of their own. We can of course resort the pivoted data, but that wouldn't change how the bars are rendered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16305: [sort by][time series bart chart v2]Sort by is not working for time series bar chart v2
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16305:
URL: https://github.com/apache/superset/issues/16305#issuecomment-900805808
thanks for catching!! @villebro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #16305: [sort by][time series bart chart v2]Sort by is not working for time series bar chart v2
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #16305:
URL: https://github.com/apache/superset/issues/16305#issuecomment-900805808
thanks for catching!! @villebro 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16305: [sort by][time series bart chart v2]Sort by is not working for time series bar chart v2
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16305:
URL: https://github.com/apache/superset/issues/16305#issuecomment-900805808
thanks for catching!! @villebro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org