You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2022/07/08 17:12:32 UTC
[GitHub] [curator] tisonkun opened a new pull request, #429: CURATOR-562. Follow up to cleanup ConnectionState#checkTimeouts references
tisonkun opened a new pull request, #429:
URL: https://github.com/apache/curator/pull/429
Signed-off-by: tison <wa...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun merged pull request #429: CURATOR-562. Follow up to cleanup ConnectionState#checkTimeouts references
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #429:
URL: https://github.com/apache/curator/pull/429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #429: CURATOR-562. Follow up to cleanup ConnectionState#checkTimeouts references
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #429:
URL: https://github.com/apache/curator/pull/429#issuecomment-1181292829
@cammckenzie Yes the semantic should be identical. It's exactly a followup to this comment (https://github.com/apache/curator/pull/348#discussion_r389262170) where `checkTimeout` has been removed but leaving code in this patch unchanged.
Actually we don't need `CuratorConnectionLossException` anymore, but `logError` needs a placeholder exception. It'd be better if you can find an existing exception as a good replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] cammckenzie commented on pull request #429: CURATOR-562. Follow up to cleanup ConnectionState#checkTimeouts references
Posted by GitBox <gi...@apache.org>.
cammckenzie commented on PR #429:
URL: https://github.com/apache/curator/pull/429#issuecomment-1181289644
hey @tisonkun , changes look fine to me and the code is clearer than before. This is functionally identical though? Or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #429: CURATOR-562. Follow up to cleanup ConnectionState#checkTimeouts references
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #429:
URL: https://github.com/apache/curator/pull/429#issuecomment-1179204884
Previous PR #348.
cc @eolivelli @Randgalt @cammckenzie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org