[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #333: HTTPCORE-700 - HttpHost genetic constructor NamedEndpoint

[GitBox <gi...@apache.org>]

arturobernalg commented on a change in pull request #333:
URL: https://github.com/apache/httpcomponents-core/pull/333#discussion_r753672231



##########
File path: httpcore5/src/test/java/org/apache/hc/core5/http/TestHttpHost.java
##########
@@ -69,6 +73,27 @@ public void testConstructor() {
         Assert.assertThrows(NullPointerException.class, () -> new HttpHost(null, (String) null, -1));
         Assert.assertThrows(IllegalArgumentException.class, () -> new HttpHost(null, "   ", -1));
         Assert.assertThrows(NullPointerException.class, () -> new HttpHost(null, (InetAddress) null, -1));
+
+        final Host host = new Host("myHost", 8080);

Review comment:
       HI @ok2c 
   I know. but it the same  whit ->
   `public HttpHost(final URIAuthority authority)`
   What you suggest that we should do?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org