[jira] [Commented] (SQOOP-632) Sqoop 2 client help text contains link to old incubator page

["Linden Hillenbrand (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527909#comment-13527909 ] 

Linden Hillenbrand commented on SQOOP-632:
------------------------------------------

Jarcec,

I cannot seem to find the same line of code in Sqoop2 Client shell, although I am on the latest branch so I may need to actually checkout 2.0.0 however that would then be a backport. Here is a link to the commit where the above was included (http://www.mail-archive.com/commits@sqoop.apache.org/msg00040.html)

+    // Figure out the max command name and shortcut length dynamically
+    int maxName = 0;
+    int maxShortcut = 0;
+    iterator = shell.getRegistry().commands().iterator();
+    while (iterator.hasNext()) {
+      Command command = iterator.next();
+      if (command.getHidden()) {
+        continue;
+      }
+
+      if (command.getName().length() > maxName) {
+        maxName = command.getName().length();
+      }
+        
+      if (command.getShortcut().length() > maxShortcut) {
+        maxShortcut = command.getShortcut().length();
+      }
+    }
+    
+    io.out.println("For information about @|green Sqoop|@, visit:");
+    io.out.println("  @|cyan http://incubator.apache.org/sqoop/|@ ");
+    io.out.println();
+
+    // List the commands we know about
+    io.out.println("Available commands:");
+    iterator = shell.getRegistry().commands().iterator();
+    while (iterator.hasNext()) {
+      Command command = iterator.next();
+      if (command.getHidden()) {
+        continue;
+      }
+
+      String paddedName =
+          StringUtils.rightPad(command.getName(), maxName);
+      String paddedShortcut =
+          StringUtils.rightPad(command.getShortcut(), maxShortcut);

However, when I checkout the current Sqoop2 codebase, I can see that it has been resolved:

iterator = shell.getRegistry().commands().iterator();
    while (iterator.hasNext()) {
      Command command = iterator.next();
      if (command.getHidden()) {
        continue;
      }

      String paddedName =
          StringUtils.rightPad(command.getName(), maxName);
      String paddedShortcut =
          StringUtils.rightPad(command.getShortcut(), maxShortcut);

                
> Sqoop 2 client help text contains link to old incubator page
> ------------------------------------------------------------
>
>                 Key: SQOOP-632
>                 URL: https://issues.apache.org/jira/browse/SQOOP-632
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Linden Hillenbrand
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 2.0.0
>
>
> Sqoop 2 command line interface will print old link to incubator page instead of our TLP page. We should change that.
> {code}
> Sqoop Shell: Type 'help' or '\h' for help.
> sqoop:000> help
> For information about Sqoop, visit:
>   http://incubator.apache.org/sqoop/ 
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira