You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Noa Resare <no...@resare.com> on 2013/02/28 16:16:43 UTC

Review Request: rpm packaging fix: Add symlink for log4j-cloud.xml in client webapp

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9677/
-----------------------------------------------------------

Review request for cloudstack.


Summary (updated)
-----------------

rpm packaging fix: Add symlink for log4j-cloud.xml in client webapp


Description (updated)
-------

web.xml now references a log4j-cloud.xml relative to the webapp root
to capture early logging from spring.  This change introduces a symlink
in the client webapp to the system wide log4j-cloud.xml which works around
a problem starting cloud-management described in CLOUDSTACK-1436


This addresses bugs CLOUDSTACK-1423 and CLOUDSTACK-1436.


Diffs (updated)
-----

  client/tomcatconf/classpath.conf.in 5625f69 

Diff: https://reviews.apache.org/r/9677/diff/


Testing (updated)
-------

Compiled this on top of latest 4.1 (f4c62a8596c3958b5051a989b02df51e2a95b398) on centos 6.3 and successfully started the cloud-management service 


Thanks,

Noa Resare


Re: Review Request: rpm packaging fix: Add symlink for log4j-cloud.xml in client webapp

Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9677/#review17199
-----------------------------------------------------------

Ship it!


Looks sane to me. 



- David Nalley


On Feb. 28, 2013, 7:08 p.m., Noa Resare wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9677/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2013, 7:08 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> web.xml now references a log4j-cloud.xml relative to the webapp root
> to capture early logging from spring.  This change introduces a symlink
> in the client webapp to the system wide log4j-cloud.xml which works around
> a problem starting cloud-management described in CLOUDSTACK-1436
> 
> 
> This addresses bugs CLOUDSTACK-1423 and CLOUDSTACK-1436.
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud.spec eb378ce 
> 
> Diff: https://reviews.apache.org/r/9677/diff/
> 
> 
> Testing
> -------
> 
> Compiled this on top of latest 4.1 (f4c62a8596c3958b5051a989b02df51e2a95b398) on centos 6.3 and successfully started the cloud-management service 
> 
> 
> Thanks,
> 
> Noa Resare
> 
>


Re: Review Request: rpm packaging fix: Add symlink for log4j-cloud.xml in client webapp

Posted by Noa Resare <no...@resare.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9677/
-----------------------------------------------------------

(Updated Feb. 28, 2013, 7:08 p.m.)


Review request for cloudstack.


Changes
-------

oops, wrong patch. 


Description
-------

web.xml now references a log4j-cloud.xml relative to the webapp root
to capture early logging from spring.  This change introduces a symlink
in the client webapp to the system wide log4j-cloud.xml which works around
a problem starting cloud-management described in CLOUDSTACK-1436


This addresses bugs CLOUDSTACK-1423 and CLOUDSTACK-1436.


Diffs (updated)
-----

  packaging/centos63/cloud.spec eb378ce 

Diff: https://reviews.apache.org/r/9677/diff/


Testing
-------

Compiled this on top of latest 4.1 (f4c62a8596c3958b5051a989b02df51e2a95b398) on centos 6.3 and successfully started the cloud-management service 


Thanks,

Noa Resare