[GitHub] [spark] viirya commented on a change in pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #28715:
URL: https://github.com/apache/spark/pull/28715#discussion_r584484987



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala
##########
@@ -124,7 +124,7 @@ case class GenerateExec(
     }
   }
 
-  override def supportCodegen: Boolean = false
+  override def supportCodegen: Boolean = super.supportCodegen && generator.supportCodegen

Review comment:
       Why we need `super.supportCodegen`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org