You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/12/16 01:39:59 UTC
Review Request 29069: Added an integration test for testing the
persistence primitives.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29069/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
Added an integration test for testing the persistence primitives.
This tests the basic persistence feature. See comments in the code.
Diffs
-----
src/Makefile.am 6f132b5a66e117c2a907763217bfafe1fce1b7a0
src/tests/persistent_volume_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29069/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 29069: Added an integration test for testing the
persistence primitives.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29069/#review65214
-----------------------------------------------------------
src/tests/persistent_volume_tests.cpp
<https://reviews.apache.org/r/29069/#comment108244>
s/size/sizeMb/ and lose the comment
src/tests/persistent_volume_tests.cpp
<https://reviews.apache.org/r/29069/#comment108245>
EXPECT_FALSE(offers1.get().empty());
src/tests/persistent_volume_tests.cpp
<https://reviews.apache.org/r/29069/#comment108246>
it's odd to me that this path isn't absolute. is this just a test thing or is it going to be like this for end users?
src/tests/persistent_volume_tests.cpp
<https://reviews.apache.org/r/29069/#comment108247>
for my edification: what does this loop do that the AWAIT_READY doesn't?
src/tests/persistent_volume_tests.cpp
<https://reviews.apache.org/r/29069/#comment108248>
EXPECT_FALSE(offers2.get().empty());
src/tests/persistent_volume_tests.cpp
<https://reviews.apache.org/r/29069/#comment108249>
this is called in the base class TearDown.
- Dominic Hamon
On Dec. 15, 2014, 5:05 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29069/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2014, 5:05 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added an integration test for testing the persistence primitives.
>
> This tests the basic persistence feature. See comments in the code.
>
>
> Diffs
> -----
>
> src/Makefile.am 6f132b5a66e117c2a907763217bfafe1fce1b7a0
> src/tests/persistent_volume_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29069/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 29069: Added an integration test for testing the
persistence primitives.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29069/
-----------------------------------------------------------
(Updated Dec. 16, 2014, 1:05 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Fixed the diff issue.
Repository: mesos-git
Description
-------
Added an integration test for testing the persistence primitives.
This tests the basic persistence feature. See comments in the code.
Diffs (updated)
-----
src/Makefile.am 6f132b5a66e117c2a907763217bfafe1fce1b7a0
src/tests/persistent_volume_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29069/diff/
Testing
-------
make check
Thanks,
Jie Yu