[GitHub] [geode] nabarunnag opened pull request #3041: GEODE-6135 - Add benchmark job to CI.

["nabarunnag (GitHub)" <gi...@apache.org>]

* Add a job to concourse for executing benchmarks
* Benchmarks run in AWS, results are stored in GCP.

Authored-by: Sean Goller <sg...@pivotal.io>
Authored-by: Helena Bales <hb...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #3041: GEODE-6135 - Add benchmark job to CI.

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

in that case, remove the `depth` flag altogether. There is no guarantee that 100 commits will be enough to get to the baseline SHA.

[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett closed pull request #3041: GEODE-6135 - Add benchmark job to CI.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

[ pull request closed by pivotal-jbarrett ]

[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] smgoller commented on pull request #3041: GEODE-6135 - Add benchmark job to CI.

["smgoller (GitHub)" <gi...@apache.org>]

The question is the overhead of maintaining a separate image (including image storage) vs a slightly larger single image. *shrug*

[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on pull request #3041: GEODE-6135 - Add benchmark job to CI.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

This is still needed? I thought we determined yesterday it was not?

[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on pull request #3041: GEODE-6135 - Add benchmark job to CI.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

Why do alpine tools, which is used by many tasks I think, need Java now?

[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on pull request #3041: GEODE-6135 - Add benchmark job to CI.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

Maybe it makes more sense to have an awl-tools image?


[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] smgoller commented on pull request #3041: GEODE-6135 - Add benchmark job to CI.

["smgoller (GitHub)" <gi...@apache.org>]

It's not, it made it back in somehow.

[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #3041: GEODE-6135 - Add benchmark job to CI.

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

Is this change within the scope of the PR? I do not see a corresponding change that defines the `boms:geode-all-bom:install` gradle task

[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] balesh2 commented on pull request #3041: GEODE-6135 - Add benchmark job to CI.

["balesh2 (GitHub)" <gi...@apache.org>]

This was required to fix errors we were having with the build. If I remember correctly, it was a job that should have been run automatically but that was not in certain cases. Sean would be able to explain this better.

[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] balesh2 commented on pull request #3041: GEODE-6135 - Add benchmark job to CI.

["balesh2 (GitHub)" <gi...@apache.org>]

Adding performance will require us to compare the performance of Geode at two different commits, so we need to check out more than just the most recent one or the commit needed for the "baseline" run will not be cloned.

[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] smgoller commented on pull request #3041: GEODE-6135 - Add benchmark job to CI.

["smgoller (GitHub)" <gi...@apache.org>]

It needs java because our scripts call java code to execute benchmarks.

[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on pull request #3041: GEODE-6135 - Add benchmark job to CI.

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

Has there been an issue with the geode repo being too shallow for some task runs?

[ Full content available at: https://github.com/apache/geode/pull/3041 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org