You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Jesse <pu...@gmail.com> on 2015/07/21 02:59:44 UTC
JSHint breaks the build again
I am sick of seeing my commits cause build CI failures because of single vs
double quote use.
Can we relax this condition? I absolutely disagree with this being an error!
Cheers,
Jesse
My team is hiring!
@purplecabbage
risingj.com
Re: JSHint breaks the build again
Posted by Jesse <pu...@gmail.com>.
yes, typically it's
"test": "npm run jshint && npm run jasmine"
My team is hiring!
@purplecabbage
risingj.com
On Wed, Jul 22, 2015 at 3:42 PM, Carlos Santana <cs...@gmail.com>
wrote:
> do we have a git commit hook in all repos that run npm test-full, and npm
> test-full includes all tests including the ones for styles
>
> On Tue, Jul 21, 2015 at 2:55 PM Rob Paveza <Ro...@microsoft.com>
> wrote:
>
> > I would be OK with a style warning as long as the warning checks the
> > contents of the string for a single-quote, in which case it says, "Oh,
> you
> > used double quotes so you could author a single quote without an escape
> > prefix! I won't error you here."
> > ________________________________________
> > From: Murat Sutunc <mu...@microsoft.com>
> > Sent: Tuesday, July 21, 2015 11:34 AM
> > To: dev@cordova.apache.org
> > Subject: RE: JSHint breaks the build again
> >
> > Yeah this rule is more of a style rule and doesn't check for language
> > correctness. I'm ok with removing it but I'm also wondering if we should
> > separately have some sort of a style checker (which will not block CI but
> > give out warnings).
> >
> > -----Original Message-----
> > From: Nikhil Khandelwal [mailto:nikhilkh@microsoft.com]
> > Sent: Tuesday, July 21, 2015 11:12 AM
> > To: dev@cordova.apache.org
> > Subject: RE: JSHint breaks the build again
> >
> > I agree with your disagreement. :)
> >
> > +1 to relaxing the condition.
> >
> > Thanks,
> > Nikhil
> >
> >
> > -----Original Message-----
> > From: Jesse [mailto:purplecabbage@gmail.com]
> > Sent: Monday, July 20, 2015 6:00 PM
> > To: dev@cordova.apache.org
> > Subject: JSHint breaks the build again
> >
> > I am sick of seeing my commits cause build CI failures because of single
> > vs double quote use.
> > Can we relax this condition? I absolutely disagree with this being an
> > error!
> >
> > Cheers,
> > Jesse
> >
> > My team is hiring!
> > @purplecabbage
> > risingj.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> B�KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB�
> > � [��X��ܚX�K K[XZ[ � ]�][��X��ܚX�P �ܙ ݘK�\ X� K�ܙ�B��܈ Y ] [ۘ[ ��[X[�
> > � K[XZ[ � ]�Z [ �ܙ ݘK�\ X� K�ܙ�B
> >
>
Re: JSHint breaks the build again
Posted by Carlos Santana <cs...@gmail.com>.
do we have a git commit hook in all repos that run npm test-full, and npm
test-full includes all tests including the ones for styles
On Tue, Jul 21, 2015 at 2:55 PM Rob Paveza <Ro...@microsoft.com> wrote:
> I would be OK with a style warning as long as the warning checks the
> contents of the string for a single-quote, in which case it says, "Oh, you
> used double quotes so you could author a single quote without an escape
> prefix! I won't error you here."
> ________________________________________
> From: Murat Sutunc <mu...@microsoft.com>
> Sent: Tuesday, July 21, 2015 11:34 AM
> To: dev@cordova.apache.org
> Subject: RE: JSHint breaks the build again
>
> Yeah this rule is more of a style rule and doesn't check for language
> correctness. I'm ok with removing it but I'm also wondering if we should
> separately have some sort of a style checker (which will not block CI but
> give out warnings).
>
> -----Original Message-----
> From: Nikhil Khandelwal [mailto:nikhilkh@microsoft.com]
> Sent: Tuesday, July 21, 2015 11:12 AM
> To: dev@cordova.apache.org
> Subject: RE: JSHint breaks the build again
>
> I agree with your disagreement. :)
>
> +1 to relaxing the condition.
>
> Thanks,
> Nikhil
>
>
> -----Original Message-----
> From: Jesse [mailto:purplecabbage@gmail.com]
> Sent: Monday, July 20, 2015 6:00 PM
> To: dev@cordova.apache.org
> Subject: JSHint breaks the build again
>
> I am sick of seeing my commits cause build CI failures because of single
> vs double quote use.
> Can we relax this condition? I absolutely disagree with this being an
> error!
>
> Cheers,
> Jesse
>
> My team is hiring!
> @purplecabbage
> risingj.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
> B�KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB�
> � [��X��ܚX�K K[XZ[ � ]�][��X��ܚX�P �ܙ ݘK�\ X� K�ܙ�B��܈ Y ] [ۘ[ ��[X[�
> � K[XZ[ � ]�Z [ �ܙ ݘK�\ X� K�ܙ�B
>
Re: JSHint breaks the build again
Posted by Rob Paveza <Ro...@microsoft.com>.
I would be OK with a style warning as long as the warning checks the contents of the string for a single-quote, in which case it says, "Oh, you used double quotes so you could author a single quote without an escape prefix! I won't error you here."
________________________________________
From: Murat Sutunc <mu...@microsoft.com>
Sent: Tuesday, July 21, 2015 11:34 AM
To: dev@cordova.apache.org
Subject: RE: JSHint breaks the build again
Yeah this rule is more of a style rule and doesn't check for language correctness. I'm ok with removing it but I'm also wondering if we should separately have some sort of a style checker (which will not block CI but give out warnings).
-----Original Message-----
From: Nikhil Khandelwal [mailto:nikhilkh@microsoft.com]
Sent: Tuesday, July 21, 2015 11:12 AM
To: dev@cordova.apache.org
Subject: RE: JSHint breaks the build again
I agree with your disagreement. :)
+1 to relaxing the condition.
Thanks,
Nikhil
-----Original Message-----
From: Jesse [mailto:purplecabbage@gmail.com]
Sent: Monday, July 20, 2015 6:00 PM
To: dev@cordova.apache.org
Subject: JSHint breaks the build again
I am sick of seeing my commits cause build CI failures because of single vs double quote use.
Can we relax this condition? I absolutely disagree with this being an error!
Cheers,
Jesse
My team is hiring!
@purplecabbage
risingj.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
B�KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB�� [��X��ܚX�KK[XZ[�]�][��X��ܚX�P�ܙݘK�\X�K�ܙ�B��܈Y][ۘ[��[X[� �K[XZ[�]�Z[ �ܙݘK�\X�K�ܙ�B
RE: JSHint breaks the build again
Posted by Murat Sutunc <mu...@microsoft.com>.
Yeah this rule is more of a style rule and doesn't check for language correctness. I'm ok with removing it but I'm also wondering if we should separately have some sort of a style checker (which will not block CI but give out warnings).
-----Original Message-----
From: Nikhil Khandelwal [mailto:nikhilkh@microsoft.com]
Sent: Tuesday, July 21, 2015 11:12 AM
To: dev@cordova.apache.org
Subject: RE: JSHint breaks the build again
I agree with your disagreement. :)
+1 to relaxing the condition.
Thanks,
Nikhil
-----Original Message-----
From: Jesse [mailto:purplecabbage@gmail.com]
Sent: Monday, July 20, 2015 6:00 PM
To: dev@cordova.apache.org
Subject: JSHint breaks the build again
I am sick of seeing my commits cause build CI failures because of single vs double quote use.
Can we relax this condition? I absolutely disagree with this being an error!
Cheers,
Jesse
My team is hiring!
@purplecabbage
risingj.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
RE: JSHint breaks the build again
Posted by Nikhil Khandelwal <ni...@microsoft.com>.
I agree with your disagreement. :)
+1 to relaxing the condition.
Thanks,
Nikhil
-----Original Message-----
From: Jesse [mailto:purplecabbage@gmail.com]
Sent: Monday, July 20, 2015 6:00 PM
To: dev@cordova.apache.org
Subject: JSHint breaks the build again
I am sick of seeing my commits cause build CI failures because of single vs double quote use.
Can we relax this condition? I absolutely disagree with this being an error!
Cheers,
Jesse
My team is hiring!
@purplecabbage
risingj.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org