You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/07 11:53:01 UTC
[GitHub] [doris] morrySnow commented on a diff in pull request #14851: [Feature](Nereids)support select-except
morrySnow commented on code in PR #14851:
URL: https://github.com/apache/doris/pull/14851#discussion_r1042076243
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -299,7 +300,7 @@ public LogicalPlan visitRegularQuerySpecification(RegularQuerySpecificationConte
SelectClauseContext selectCtx = ctx.selectClause();
LogicalPlan selectPlan;
if (ctx.fromClause() == null) {
- selectPlan = withOneRowRelation(selectCtx);
+ selectPlan = withOneRowRelation(selectCtx.selectColumnClause());
Review Comment:
except could not work on one row relation, forbid it
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -1059,15 +1064,20 @@ private LogicalPlan withSelectHint(LogicalPlan logicalPlan, SelectHintContext hi
return new LogicalSelectHint<>(hints, logicalPlan);
}
- private LogicalPlan withProjection(LogicalPlan input, SelectClauseContext selectCtx,
+ private LogicalPlan withProjection(LogicalPlan input, SelectColumnClauseContext selectCtx,
Optional<AggClauseContext> aggCtx) {
return ParserUtils.withOrigin(selectCtx, () -> {
// TODO: skip if havingClause exists
if (aggCtx.isPresent()) {
return input;
} else {
- List<NamedExpression> projects = getNamedExpressions(selectCtx.namedExpressionSeq());
- return new LogicalProject<>(projects, input);
+ if (selectCtx.namedExpressionSeq() != null) {
+ List<NamedExpression> projects = getNamedExpressions(selectCtx.namedExpressionSeq());
+ return new LogicalProject<>(projects, Collections.emptyList(), input);
+ } else {
+ return new LogicalProject<>(ImmutableList.of(new UnboundStar(Collections.emptyList())),
+ getNamedExpressions(selectCtx.namedExpressionSeq()), input);
+ }
Review Comment:
```java
if (selectCtx.EXCEPT() != null) {
// except ...
} else {
// normal
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org