[GitHub] [spark] zhengruifeng commented on a diff in pull request #42869: [SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #42869:
URL: https://github.com/apache/spark/pull/42869#discussion_r1321232095


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -2632,7 +2632,7 @@ object functions {
    * @group math_funcs
    * @since 3.4.0
    */
-  def log(e: Column): Column = Column.fn("log", e)

Review Comment:
   If we want to directly backport this fix to 3.4, I think `Column.fn("ln", e)` maybe better, otherwise, we may need separate PR for 3.4 since `def ln` was added in 3.5.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org