You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "haizhou-zhao (via GitHub)" <gi...@apache.org> on 2023/03/28 17:52:53 UTC
[GitHub] [iceberg] haizhou-zhao opened a new pull request, #7229: [Rest Catalog Spec] Return 204 on no content response
haizhou-zhao opened a new pull request, #7229:
URL: https://github.com/apache/iceberg/pull/7229
Change list:
1. Change success code of `tableExists` and `renameTable` from HTTP 200 to HTTP 204
Incentive:
According to [RFC spec](https://www.rfc-editor.org/rfc/rfc7231#section-6.3.1), if HTTP 200 is returned, then the response always have payload content. However, the 2 APIs above does not seem to have any return payload, for which cases, the correct success code should be 204.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] haizhou-zhao commented on pull request #7229: [Rest Catalog Spec] Return 204 on no content response
Posted by "haizhou-zhao (via GitHub)" <gi...@apache.org>.
haizhou-zhao commented on PR #7229:
URL: https://github.com/apache/iceberg/pull/7229#issuecomment-1505786302
Thanks both @dramaticlly @Fokko for your review!
@Fokko Updated description based on your suggestions. Feel free to check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] haizhou-zhao commented on pull request #7229: [Rest Catalog Spec] Return 204 on no content response
Posted by "haizhou-zhao (via GitHub)" <gi...@apache.org>.
haizhou-zhao commented on PR #7229:
URL: https://github.com/apache/iceberg/pull/7229#issuecomment-1487369017
@Fokko Would be great if you can help review. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] haizhou-zhao commented on pull request #7229: [Rest Catalog Spec] Return 204 on no content response
Posted by "haizhou-zhao (via GitHub)" <gi...@apache.org>.
haizhou-zhao commented on PR #7229:
URL: https://github.com/apache/iceberg/pull/7229#issuecomment-1563385290
@Fokko Let me know if you can still help with merging this PR. Thanks a lot for your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra merged pull request #7229: [Rest Catalog Spec] Return 204 on no content response
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #7229:
URL: https://github.com/apache/iceberg/pull/7229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #7229: [Rest Catalog Spec] Return 204 on no content response
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #7229:
URL: https://github.com/apache/iceberg/pull/7229#discussion_r1162427743
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -725,7 +725,7 @@ paths:
description:
Check if a table exists within a given namespace. This request does not return a response body.
responses:
- 200:
+ 204:
description: OK - Table Exists
Review Comment:
```suggestion
description: Success, no content
```
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -763,7 +763,7 @@ paths:
$ref: '#/components/examples/RenameTableSameNamespace'
required: true
responses:
- 200:
+ 204:
description: OK
Review Comment:
```suggestion
description: Success, no content
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] dramaticlly commented on pull request #7229: [Rest Catalog Spec] Return 204 on no content response
Posted by "dramaticlly (via GitHub)" <gi...@apache.org>.
dramaticlly commented on PR #7229:
URL: https://github.com/apache/iceberg/pull/7229#issuecomment-1487699994
Looks like we also did similar change in #4366, @rdblue and @danielcweeks if you can help review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org