[GitHub] [phoenix] gjacoby126 commented on a diff in pull request #1439: PHOENIX-6688 Upgrade to phoenix 4.16 metadata upgrade fails when SYSAT has large number of tenant views

[GitBox <gi...@apache.org>]

gjacoby126 commented on code in PR #1439:
URL: https://github.com/apache/phoenix/pull/1439#discussion_r870641315


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpgradeIT.java:
##########
@@ -357,11 +379,29 @@ public void testMoveParentChildLinks() throws Exception {
             phxMetaConn.setRunningUpgrade(true);
             // create the parent-> child links in SYSTEM.CATALOG
             UpgradeUtil.addParentToChildLinks(phxMetaConn);
+
+            // Increase the timeouts so that the scan queries during moveOrCopyChildLinks do not timeout on large syscat's
+            Map<String, String> options = new HashMap<>();
+            options.put(HConstants.HBASE_RPC_TIMEOUT_KEY, Integer.toString(DEFAULT_TIMEOUT_DURING_UPGRADE_MS));
+            options.put(HConstants.HBASE_CLIENT_SCANNER_TIMEOUT_PERIOD, Integer.toString(DEFAULT_TIMEOUT_DURING_UPGRADE_MS));
+            String clientPort = getUtility().getConfiguration().get(QueryServices.ZOOKEEPER_PORT_ATTRIB);
+
+            String localQuorum = String.format("localhost:%s", clientPort);

Review Comment:
   nit: can't you get the quorum from the config?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org