ReviewBoard

[Franz de Copenhague <fr...@outlook.com>]

ReviewBoard is a very productive tool to review code and I have realized
that apache has this tool. https://reviews.apache.org/groups

 

So far, I have learnt that each project has its corresponding group in
review board. I would like to use this tool to submit patches and code
change, and other developers can review them and discuss the changes and
provide feedbacks at coding level.

 

I don't know who administrate reviewboard to request a new group for
Corinthia project.

 

Juande

 

 

Re: ReviewBoard

[Gabriela Gibson <ga...@gmail.com>]

On 26 Mar 2015 16:50, "jan i" <ja...@apache.org> wrote:
>
> On 26 March 2015 at 17:44, Gabriela Gibson <ga...@gmail.com>
> wrote:
>
> > Thanks Jan (and Franz!),
> >
> > I can make a page on the wiki about it, once I have the net back.
> >
> Sounds good, but you will not the the net back, I am some other millions
of
> users need it :-)
>
> Since it is Thursday, you might get access to it.
>
> And do please remember I am about 3.000km away, so physical violence is
> very hard.
>
> Have a nice evening.
> rgds
> jan i.
>
> Ps. When do you think you will have a stable connection again ?
>

I need a 'special' modem which is with An Post, the local postal service.
I do not recommend the disservice of this company unless you enjoy epic
incompetence.

I am told they reliably failed to locate Google Docks in Dublin for
delivery of a book.

In my case, the initial problem was a failure to operate the doorbell
successfully, followed by the inability to tear off a parcel number sticker
without truncating it and the timing out my websession out after taking my
payment, after customer service taught me the trick to cheat their buggy
website into working.

Oh and the phone number on the leaflet was no longer valid.  I spare you
the rest but no potential problem was omitted so far.  Very comprehensive.

Sky tells me in their letter dated 16th which An Post delivered this
morning: 'a few days' before connection and gives me the friedly advice to
'put my feet up' in the meanwhile.

So I guess I'll be finding out exactly how long a piece of string is.

All this for a broadband connection speed of 3mb.

Maybe I should look into that carrier pidgeon protocol I vaguely remember
exists for unix.

:-D

G

>
> > G
> > On 26 Mar 2015 16:24, "jan i" <ja...@apache.org> wrote:
> >
> > > Corinthia is created on reviewBoard.
> > >
> > > rgds
> > > jan i.
> > >
> > > On 23 March 2015 at 20:35, jan i <ja...@apache.org> wrote:
> > >
> > > > Hi.
> > > >
> > > > For Info, I have created:
> > > > https://issues.apache.org/jira/browse/INFRA-9323
> > > >
> > > > to hopefully make this happen.
> > > >
> > > > rgds
> > > > jan I.
> > > >
> > > >
> > > > On 23 March 2015 at 20:07, Gabriela Gibson <
gabriela.gibson@gmail.com>
> > > > wrote:
> > > >
> > > >> Oh I c.  That looks pretty neat.   The automated uploading tools
look
> > > >> inviting, so does the diff display.
> > > >>
> > > >> I would definitely be interested in trying it out :-)
> > > >>
> > > >> G
> > > >> On 23 Mar 2015 18:08, "Franz de Copenhague" <
> > > >> franzdecopenhague@outlook.com>
> > > >> wrote:
> > > >>
> > > >> >
> > > >> >
> > > >> > ----------------------------------------
> > > >> > >
> > > >> > > 1. What does the review tool give us that Jira or the mailing
list
> > > >> > doesn't?
> > > >> >
> > > >> > Basically ReviewBoard allows us to send a code review of our code
> > > >> without
> > > >> > sending a patch and it has a mechanism to provide feedback in the
> > code
> > > >> > review. For example:  https://reviews.apache.org/r/32219/diff/#
> > > >> >
> > > >> > >
> > > >> > > 2. How would we use Jira together with the review tool?
> > > >> >
> > > >> > In any JIRA comment just add a link to the reviewboard and people
> > can
> > > >> > access to your code. Like this says:
> > > >> > https://cwiki.apache.org/confluence/display/Hive/Review+Board
> > > >> >
> > > >> > >
> > > >> > > 3. I just realised I didn't close issues I resolved in Jira
(will
> > do
> > > >> > once I
> > > >> > > have inet back) so I am wondering about the extra
administrative
> > > >> overhead
> > > >> > > using the review board this would add, as in that we would
have to
> > > >> keep 2
> > > >> > > tools up to date and have 3 places to visit.
> > > >> > >
> > > >> >
> > > >> > After getting a code review request people use to click on "ship
it"
> > > >> check
> > > >> > box or send back their concerns. This is the only thing to do
with
> > > >> > ReviewBoard. The rest of task managment workflow is done in JIRA
> > like
> > > >> it is
> > > >> > now.
> > > >> >
> > > >> >
> > > >> > franz
> > > >>
> > > >
> > > >
> > >
> >

Re: ReviewBoard

[jan i <ja...@apache.org>]

On 26 March 2015 at 17:44, Gabriela Gibson <ga...@gmail.com>
wrote:

> Thanks Jan (and Franz!),
>
> I can make a page on the wiki about it, once I have the net back.
>
Sounds good, but you will not the the net back, I am some other millions of
users need it :-)

Since it is Thursday, you might get access to it.

And do please remember I am about 3.000km away, so physical violence is
very hard.

Have a nice evening.
rgds
jan i.

Ps. When do you think you will have a stable connection again ?


> G
> On 26 Mar 2015 16:24, "jan i" <ja...@apache.org> wrote:
>
> > Corinthia is created on reviewBoard.
> >
> > rgds
> > jan i.
> >
> > On 23 March 2015 at 20:35, jan i <ja...@apache.org> wrote:
> >
> > > Hi.
> > >
> > > For Info, I have created:
> > > https://issues.apache.org/jira/browse/INFRA-9323
> > >
> > > to hopefully make this happen.
> > >
> > > rgds
> > > jan I.
> > >
> > >
> > > On 23 March 2015 at 20:07, Gabriela Gibson <ga...@gmail.com>
> > > wrote:
> > >
> > >> Oh I c.  That looks pretty neat.   The automated uploading tools look
> > >> inviting, so does the diff display.
> > >>
> > >> I would definitely be interested in trying it out :-)
> > >>
> > >> G
> > >> On 23 Mar 2015 18:08, "Franz de Copenhague" <
> > >> franzdecopenhague@outlook.com>
> > >> wrote:
> > >>
> > >> >
> > >> >
> > >> > ----------------------------------------
> > >> > >
> > >> > > 1. What does the review tool give us that Jira or the mailing list
> > >> > doesn't?
> > >> >
> > >> > Basically ReviewBoard allows us to send a code review of our code
> > >> without
> > >> > sending a patch and it has a mechanism to provide feedback in the
> code
> > >> > review. For example:  https://reviews.apache.org/r/32219/diff/#
> > >> >
> > >> > >
> > >> > > 2. How would we use Jira together with the review tool?
> > >> >
> > >> > In any JIRA comment just add a link to the reviewboard and people
> can
> > >> > access to your code. Like this says:
> > >> > https://cwiki.apache.org/confluence/display/Hive/Review+Board
> > >> >
> > >> > >
> > >> > > 3. I just realised I didn't close issues I resolved in Jira (will
> do
> > >> > once I
> > >> > > have inet back) so I am wondering about the extra administrative
> > >> overhead
> > >> > > using the review board this would add, as in that we would have to
> > >> keep 2
> > >> > > tools up to date and have 3 places to visit.
> > >> > >
> > >> >
> > >> > After getting a code review request people use to click on "ship it"
> > >> check
> > >> > box or send back their concerns. This is the only thing to do with
> > >> > ReviewBoard. The rest of task managment workflow is done in JIRA
> like
> > >> it is
> > >> > now.
> > >> >
> > >> >
> > >> > franz
> > >>
> > >
> > >
> >
>

Re: ReviewBoard

[Gabriela Gibson <ga...@gmail.com>]

Thanks Jan (and Franz!),

I can make a page on the wiki about it, once I have the net back.

G
On 26 Mar 2015 16:24, "jan i" <ja...@apache.org> wrote:

> Corinthia is created on reviewBoard.
>
> rgds
> jan i.
>
> On 23 March 2015 at 20:35, jan i <ja...@apache.org> wrote:
>
> > Hi.
> >
> > For Info, I have created:
> > https://issues.apache.org/jira/browse/INFRA-9323
> >
> > to hopefully make this happen.
> >
> > rgds
> > jan I.
> >
> >
> > On 23 March 2015 at 20:07, Gabriela Gibson <ga...@gmail.com>
> > wrote:
> >
> >> Oh I c.  That looks pretty neat.   The automated uploading tools look
> >> inviting, so does the diff display.
> >>
> >> I would definitely be interested in trying it out :-)
> >>
> >> G
> >> On 23 Mar 2015 18:08, "Franz de Copenhague" <
> >> franzdecopenhague@outlook.com>
> >> wrote:
> >>
> >> >
> >> >
> >> > ----------------------------------------
> >> > >
> >> > > 1. What does the review tool give us that Jira or the mailing list
> >> > doesn't?
> >> >
> >> > Basically ReviewBoard allows us to send a code review of our code
> >> without
> >> > sending a patch and it has a mechanism to provide feedback in the code
> >> > review. For example:  https://reviews.apache.org/r/32219/diff/#
> >> >
> >> > >
> >> > > 2. How would we use Jira together with the review tool?
> >> >
> >> > In any JIRA comment just add a link to the reviewboard and people can
> >> > access to your code. Like this says:
> >> > https://cwiki.apache.org/confluence/display/Hive/Review+Board
> >> >
> >> > >
> >> > > 3. I just realised I didn't close issues I resolved in Jira (will do
> >> > once I
> >> > > have inet back) so I am wondering about the extra administrative
> >> overhead
> >> > > using the review board this would add, as in that we would have to
> >> keep 2
> >> > > tools up to date and have 3 places to visit.
> >> > >
> >> >
> >> > After getting a code review request people use to click on "ship it"
> >> check
> >> > box or send back their concerns. This is the only thing to do with
> >> > ReviewBoard. The rest of task managment workflow is done in JIRA like
> >> it is
> >> > now.
> >> >
> >> >
> >> > franz
> >>
> >
> >
>

Re: ReviewBoard

[jan i <ja...@apache.org>]

Corinthia is created on reviewBoard.

rgds
jan i.

On 23 March 2015 at 20:35, jan i <ja...@apache.org> wrote:

> Hi.
>
> For Info, I have created:
> https://issues.apache.org/jira/browse/INFRA-9323
>
> to hopefully make this happen.
>
> rgds
> jan I.
>
>
> On 23 March 2015 at 20:07, Gabriela Gibson <ga...@gmail.com>
> wrote:
>
>> Oh I c.  That looks pretty neat.   The automated uploading tools look
>> inviting, so does the diff display.
>>
>> I would definitely be interested in trying it out :-)
>>
>> G
>> On 23 Mar 2015 18:08, "Franz de Copenhague" <
>> franzdecopenhague@outlook.com>
>> wrote:
>>
>> >
>> >
>> > ----------------------------------------
>> > >
>> > > 1. What does the review tool give us that Jira or the mailing list
>> > doesn't?
>> >
>> > Basically ReviewBoard allows us to send a code review of our code
>> without
>> > sending a patch and it has a mechanism to provide feedback in the code
>> > review. For example:  https://reviews.apache.org/r/32219/diff/#
>> >
>> > >
>> > > 2. How would we use Jira together with the review tool?
>> >
>> > In any JIRA comment just add a link to the reviewboard and people can
>> > access to your code. Like this says:
>> > https://cwiki.apache.org/confluence/display/Hive/Review+Board
>> >
>> > >
>> > > 3. I just realised I didn't close issues I resolved in Jira (will do
>> > once I
>> > > have inet back) so I am wondering about the extra administrative
>> overhead
>> > > using the review board this would add, as in that we would have to
>> keep 2
>> > > tools up to date and have 3 places to visit.
>> > >
>> >
>> > After getting a code review request people use to click on "ship it"
>> check
>> > box or send back their concerns. This is the only thing to do with
>> > ReviewBoard. The rest of task managment workflow is done in JIRA like
>> it is
>> > now.
>> >
>> >
>> > franz
>>
>
>

Re: ReviewBoard

[jan i <ja...@apache.org>]

Hi.

For Info, I have created:
https://issues.apache.org/jira/browse/INFRA-9323

to hopefully make this happen.

rgds
jan I.


On 23 March 2015 at 20:07, Gabriela Gibson <ga...@gmail.com>
wrote:

> Oh I c.  That looks pretty neat.   The automated uploading tools look
> inviting, so does the diff display.
>
> I would definitely be interested in trying it out :-)
>
> G
> On 23 Mar 2015 18:08, "Franz de Copenhague" <franzdecopenhague@outlook.com
> >
> wrote:
>
> >
> >
> > ----------------------------------------
> > >
> > > 1. What does the review tool give us that Jira or the mailing list
> > doesn't?
> >
> > Basically ReviewBoard allows us to send a code review of our code without
> > sending a patch and it has a mechanism to provide feedback in the code
> > review. For example:  https://reviews.apache.org/r/32219/diff/#
> >
> > >
> > > 2. How would we use Jira together with the review tool?
> >
> > In any JIRA comment just add a link to the reviewboard and people can
> > access to your code. Like this says:
> > https://cwiki.apache.org/confluence/display/Hive/Review+Board
> >
> > >
> > > 3. I just realised I didn't close issues I resolved in Jira (will do
> > once I
> > > have inet back) so I am wondering about the extra administrative
> overhead
> > > using the review board this would add, as in that we would have to
> keep 2
> > > tools up to date and have 3 places to visit.
> > >
> >
> > After getting a code review request people use to click on "ship it"
> check
> > box or send back their concerns. This is the only thing to do with
> > ReviewBoard. The rest of task managment workflow is done in JIRA like it
> is
> > now.
> >
> >
> > franz
>

RE: ReviewBoard

[Gabriela Gibson <ga...@gmail.com>]

Oh I c.  That looks pretty neat.   The automated uploading tools look
inviting, so does the diff display.

I would definitely be interested in trying it out :-)

G
On 23 Mar 2015 18:08, "Franz de Copenhague" <fr...@outlook.com>
wrote:

>
>
> ----------------------------------------
> >
> > 1. What does the review tool give us that Jira or the mailing list
> doesn't?
>
> Basically ReviewBoard allows us to send a code review of our code without
> sending a patch and it has a mechanism to provide feedback in the code
> review. For example:  https://reviews.apache.org/r/32219/diff/#
>
> >
> > 2. How would we use Jira together with the review tool?
>
> In any JIRA comment just add a link to the reviewboard and people can
> access to your code. Like this says:
> https://cwiki.apache.org/confluence/display/Hive/Review+Board
>
> >
> > 3. I just realised I didn't close issues I resolved in Jira (will do
> once I
> > have inet back) so I am wondering about the extra administrative overhead
> > using the review board this would add, as in that we would have to keep 2
> > tools up to date and have 3 places to visit.
> >
>
> After getting a code review request people use to click on "ship it" check
> box or send back their concerns. This is the only thing to do with
> ReviewBoard. The rest of task managment workflow is done in JIRA like it is
> now.
>
>
> franz

RE: ReviewBoard

[Franz de Copenhague <fr...@outlook.com>]

----------------------------------------
>
> 1. What does the review tool give us that Jira or the mailing list doesn't?

Basically ReviewBoard allows us to send a code review of our code without sending a patch and it has a mechanism to provide feedback in the code review. For example:  https://reviews.apache.org/r/32219/diff/#

>
> 2. How would we use Jira together with the review tool?

In any JIRA comment just add a link to the reviewboard and people can access to your code. Like this says: https://cwiki.apache.org/confluence/display/Hive/Review+Board

>
> 3. I just realised I didn't close issues I resolved in Jira (will do once I
> have inet back) so I am wondering about the extra administrative overhead
> using the review board this would add, as in that we would have to keep 2
> tools up to date and have 3 places to visit.
>

After getting a code review request people use to click on "ship it" check box or send back their concerns. This is the only thing to do with ReviewBoard. The rest of task managment workflow is done in JIRA like it is now.


franz 		 	   		  

RE: ReviewBoard

[Gabriela Gibson <ga...@gmail.com>]

I only have a mobile atm for inet access(with a very slow connection so
things like Jira take years to load and the screen is tiny), so pardon the
questions:

1. What does the review tool give us that Jira or the mailing list doesn't?

2. How would we use Jira together with the review tool?

3. I just realised I didn't close issues I resolved in Jira (will do once I
have inet back) so I am wondering about the extra administrative overhead
using the review board this would add, as in that we would have to keep 2
tools up to date and have 3 places to visit.

Note I'm not against or for it, just not sure how to work this all :-)

G
On 23 Mar 2015 16:58, "Franz de Copenhague" <fr...@outlook.com>
wrote:

> >
> > Having used many such tools I’ve come to like Jira, despite its flaws.
> Also: it’s what others here (Apache) use. That’s not irrelevant, esp. if we
> want to engage others within Apache.
> >
> > louis
>
> Again, JIRA and ReviewBoard are complementary tools and JIRA is on top of
> ReviewBoard. Many apache projects are using both, for example:
>
> https://cwiki.apache.org/confluence/display/Hive/Review+Board
>
> http://tajo.apache.org/review-request-tool.html
>
> franz

RE: ReviewBoard

[Franz de Copenhague <fr...@outlook.com>]

>
> Having used many such tools I’ve come to like Jira, despite its flaws. Also: it’s what others here (Apache) use. That’s not irrelevant, esp. if we want to engage others within Apache.
>
> louis

Again, JIRA and ReviewBoard are complementary tools and JIRA is on top of ReviewBoard. Many apache projects are using both, for example:

https://cwiki.apache.org/confluence/display/Hive/Review+Board

http://tajo.apache.org/review-request-tool.html

franz 		 	   		  

Re: ReviewBoard

[Louis Suárez-Potts <lu...@gmail.com>]

> On 23 Mar 2015, at 10:32, jan i <ja...@apache.org> wrote:
> 
> On 23 March 2015 at 13:09, Franz de Copenhague <
> franzdecopenhague@outlook.com> wrote:
> 
>> ReviewBoard is a very productive tool to review code and I have realized
>> that apache has this tool. https://reviews.apache.org/groups
>> 
>> 
>> 
>> So far, I have learnt that each project has its corresponding group in
>> review board. I would like to use this tool to submit patches and code
>> change, and other developers can review them and discuss the changes and
>> provide feedbacks at coding level.
>> 
>> 
>> 
>> I don't know who administrate reviewboard to request a new group for
>> Corinthia project.
>> 
> 
> I have an idea, let me check it.
> 
> But I do think that Jira is a better tool, because we then have the history.
> 
> I have no strong bias on reviewboard or jira, but I think we should only
> use one of them.
> 
> What do others think?

Having used many such tools I’ve come to like Jira, despite its flaws. Also: it’s what others here (Apache) use. That’s not irrelevant, esp. if we want to engage others within Apache.

louis
 
> 
> rgds
> jan I.
> 
> 
>> 
>> 
>> Juande
>> 
>> 
>> 
>> 
>> 
>> 

Re: ReviewBoard

[jan i <ja...@apache.org>]

On 23 March 2015 at 13:09, Franz de Copenhague <
franzdecopenhague@outlook.com> wrote:

> ReviewBoard is a very productive tool to review code and I have realized
> that apache has this tool. https://reviews.apache.org/groups
>
>
>
> So far, I have learnt that each project has its corresponding group in
> review board. I would like to use this tool to submit patches and code
> change, and other developers can review them and discuss the changes and
> provide feedbacks at coding level.
>
>
>
> I don't know who administrate reviewboard to request a new group for
> Corinthia project.
>

I have an idea, let me check it.

But I do think that Jira is a better tool, because we then have the history.

I have no strong bias on reviewboard or jira, but I think we should only
use one of them.

What do others think?

rgds
jan I.


>
>
> Juande
>
>
>
>
>
>