[GitHub] [ozone] vivekratnavel commented on a change in pull request #2285: HDDS-4483. Datanodes should send last processed CRL sequence ID in heartbeats

[GitBox <gi...@apache.org>]

vivekratnavel commented on a change in pull request #2285:
URL: https://github.com/apache/ozone/pull/2285#discussion_r644312397



##########
File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/statemachine/TestStateContext.java
##########
@@ -126,6 +126,12 @@ public void testPutBackReports() {
       fail("Should throw exception when putting back unaccepted reports!");
     } catch (IllegalArgumentException ignored) {
     }
+    try {

Review comment:
       Yes. Some reports like incremental container reports support putback, but we don't want to put back the CRL status report in any scenario. Even if the report doesn't get delivered to SCM, a new report will be generated in the next heartbeat. This test is to affirm that an exception is thrown while putting back the CRL status report.

##########
File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/statemachine/TestStateContext.java
##########
@@ -190,46 +197,6 @@ public void testReportQueueWithAddReports() {
 
     Map<String, Integer> expectedReportCount = new HashMap<>();
 
-    // Add a bunch of ContainerReports

Review comment:
       I deleted these tests because they are already covered in a different method(testGetReports()) in the same file. This is to avoid redundant testing. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org