[GitHub] vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

[GitBox <gi...@apache.org>]

vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#issuecomment-424602274
 
 
   @lushuifeng, thanks for the contribution!
   
   Besides setters added to the generated code, are there any changes which optimize the generated code, are these setters used somewhere?
   
   Please note, that Drill has its own framework for scalar replacement and passing value holders to the methods as arguments may break a scalar replacement for those holders.
   
   Also, Drill can generate too large classes. To avoid problems with the class constant pool overflow was implemented splitting the classes into the smaller ones. Is this change incorporates or at least does not break it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services