You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "janhoy (via GitHub)" <gi...@apache.org> on 2026/01/02 11:45:59 UTC
[PR] The validate-changelog workflow should allow deleted yml file [solr]
janhoy opened a new pull request, #3999:
URL: https://github.com/apache/solr/pull/3999
In case a `changelog/unreleased/foo.yml` file is deleted, the current logic of the workflow is to pass the file-name of the deleted yml to the `validate-changelog-yaml.py`, which then of course fails since the file does not exist.
The workflow should only try to validate actually existing files, so a delete should be ignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] The validate-changelog workflow should allow deleted yml file [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #3999:
URL: https://github.com/apache/solr/pull/3999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] The validate-changelog workflow should allow deleted yml file [solr]
Posted by "gus-asf (via GitHub)" <gi...@apache.org>.
gus-asf commented on PR #3999:
URL: https://github.com/apache/solr/pull/3999#issuecomment-3705311626
Looks good, deletions in change logs is something reviewers should usually question if they are paying attention anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org