[jira] [Work logged] (TS-2482) Problems with SOCKS

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-2482?focusedWorklogId=31703&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31703 ]

ASF GitHub Bot logged work on TS-2482:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Nov/16 03:56
            Start Date: 07/Nov/16 03:56
    Worklog Time Spent: 10m 
      Work Description: GitHub user oknet opened a pull request:

    https://github.com/apache/trafficserver/pull/1203

    TS-2482: Should use target_addr instead of server_addr when build socks request

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oknet/trafficserver TS-2482-6.2.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1203
    
----
commit 2649338f1142337ff0b7b28be3e65178ce7b2818
Author: Oknet Xu <xu...@skyguard.com.cn>
Date:   2016-08-27T12:18:06Z

    TS-2482: Should use target_addr instead of server_addr when build socks request.
    
    (cherry picked from commit 15b8263f6f8cdc39b4e28ebf5d20d311ce0a0eb3)

----


Issue Time Tracking
-------------------

    Worklog Id:     (was: 31703)
    Time Spent: 2h 40m  (was: 2.5h)

> Problems with SOCKS
> -------------------
>
>                 Key: TS-2482
>                 URL: https://issues.apache.org/jira/browse/TS-2482
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core, SOCKS
>            Reporter: Radim Kolar
>            Assignee: Oknet Xu
>             Fix For: 7.0.0
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> There are several problems with using SOCKS. I am interested in case when TF is sock client. Client sends HTTP request and TF uses SOCKS server to make connection to internet.
> a/ - not documented enough in default configs
> From default configs comments it seems that for running 
> TF 4.1.2 as socks client, it is sufficient to add one line to socks.config:
> dest_ip=0.0.0.0-255.255.255.255 parent="10.0.0.7:9050"
> but socks proxy is not used. If i run tcpdump sniffing packets  TF never tries to connect to that SOCKS.
> From source code - https://github.com/apache/trafficserver/blob/master/iocore/net/Socks.cc it looks that is needed to set "proxy.config.socks.socks_needed" to activate socks support. This should be documented in both sample files: socks.config and record.config
> b/
> after enabling socks, i am hit by this assert:
> Assertion failed: (ats_is_ip4(&target_addr)), function init, file Socks.cc, line 65.
> i run on dual stack system (ip4,ip6). 
> This code is setting default destination for SOCKS request? Can not you use just 127.0.0.1 for case if client gets connected over IP6?
> https://github.com/apache/trafficserver/blob/master/iocore/net/Socks.cc#L66



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)