[GitHub] spark pull request #16855: [SPARK-13931] Stage can hang if an executor fails...

[GavinGavinNo1 <gi...@git.apache.org>]

Github user GavinGavinNo1 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16855#discussion_r100346247
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -874,7 +874,8 @@ private[spark] class TaskSetManager(
         // and we are not using an external shuffle server which could serve the shuffle outputs.
         // The reason is the next stage wouldn't be able to fetch the data from this dead executor
         // so we would need to rerun these tasks on other executors.
    -    if (tasks(0).isInstanceOf[ShuffleMapTask] && !env.blockManager.externalShuffleServiceEnabled) {
    +    if (tasks(0).isInstanceOf[ShuffleMapTask] && !env.blockManager.externalShuffleServiceEnabled
    +      && !isZombie) {
    --- End diff --
    
    @kayousterhout I think, when TSM is a zombie, resubmitted tasks won't be offered or executed, so it's no need to notify the DAGScheduler that tasks are finished.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org